All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Jesper Nilsson <Jesper.Nilsson@axis.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: chris: struct device - replace bus_id with dev_name(), dev_set_name()
Date: Mon, 17 Nov 2008 14:53:59 -0800	[thread overview]
Message-ID: <20081117225359.GB10377@kroah.com> (raw)
In-Reply-To: <20081107120136.GD4013@axis.com>

On Fri, Nov 07, 2008 at 01:01:36PM +0100, Jesper Nilsson wrote:
> On Fri, Nov 07, 2008 at 01:38:40AM +0100, Kay Sievers wrote:
> > This patch is part of a larger patch series which will remove
> > the "char bus_id[20]" name string from struct device. The device
> > name is managed in the kobject anyway, and without any size
> > limitation, and just needlessly copied into "struct device".
> 
> Thanks, but I think that since this driver has been broken a long time
> it is high time to fix it, and I think the fix removes the need for your patch.
> 
> Greg, could you please look this patch over?
> 
> 
> [CRISv32] Fix IOP fw-loader to use platform_device.
> 
> Change IOP fw-loader to use platform_device instead of
> raw device, which should be more correct usage.
> 
> Signed-off-by: Stefan Andersson <stefan.andersson@axis.com>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>

Looks sane to me.  Want me to take it through my tree, or will you be
submitting it?

thanks,

greg k-h

  reply	other threads:[~2008-11-17 23:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07  0:38 chris: struct device - replace bus_id with dev_name(), dev_set_name() Kay Sievers
2008-11-07 12:01 ` Jesper Nilsson
2008-11-17 22:53   ` Greg KH [this message]
2008-11-18  8:14     ` Jesper Nilsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081117225359.GB10377@kroah.com \
    --to=greg@kroah.com \
    --cc=Jesper.Nilsson@axis.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.