From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/2] k8temp add support for family 10h
Date: Tue, 18 Nov 2008 09:34:13 +0000 [thread overview]
Message-ID: <20081118093413.GH12095@alberich.amd.com> (raw)
In-Reply-To: <48E3F7B6.4000901@assembler.cz>
On Mon, Nov 10, 2008 at 10:34:10AM +0100, Jean Delvare wrote:
> On Thu, 02 Oct 2008 00:20:38 +0200, Rudolf Marek wrote:
> > What do you think?
>
> Looking at your patch, there doesn't seem to be much in common between
> the family 0Fh and the family 10h. The temperature conversion formula
> is different, the registers are different... And I seem to understand
> that the family 10h has a single sensor? In the end your patch is
> larger than the k8temp driver itself. So I am wondering, does it really
> make sense to support both families with the same driver?
IMHO this makes sense. The user just needs to switch on
CONFIG_SENSORS_K8TEMP on a system with newer AMD CPUs (regardless
whether the CPU is family 0xf, 0x10 or 0x11) and the driver is able to
handle the CPU temperature sensor.
It's the same with powernow-k8. This cpufreq driver is used for all
newer AMD CPU families as well.
Regards,
Andreas
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2008-11-18 9:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 22:20 [lm-sensors] [PATCH 2/2] k8temp add support for family 10h and 11h Rudolf Marek
2008-10-06 15:00 ` [lm-sensors] [PATCH 2/2] k8temp add support for family 10h and Andreas Herrmann
2008-10-06 17:37 ` Jean-Marc Spaggiari
2008-11-10 9:34 ` Jean Delvare
2008-11-18 9:34 ` Andreas Herrmann [this message]
2008-11-18 10:50 ` Jean Delvare
2009-01-25 15:22 ` Michael R. Doerner
2009-02-22 18:48 ` Michael R. Doerner
2009-09-07 0:27 ` Rob Robason
2009-09-14 10:10 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118093413.GH12095@alberich.amd.com \
--to=andreas.herrmann3@amd.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.