Re: [lm-sensors] [PATCH 1/2] k8temp warn about errata

[Andreas Herrmann <andreas.herrmann3@amd.com>]

Hi Rudolf,

On Thu, Oct 02, 2008 at 12:09:09AM +0200, Rudolf Marek wrote:
> Index: linux-2.6.27-rc7/drivers/hwmon/k8temp.c
> =================================> --- linux-2.6.27-rc7.orig/drivers/hwmon/k8temp.c	2008-09-28 11:01:45.855284456 +0200
> +++ linux-2.6.27-rc7/drivers/hwmon/k8temp.c	2008-09-28 11:13:42.396117790 +0200
> @@ -155,6 +158,18 @@
>  		goto exit;
>  	}
>  
> +	/* get real PCI based cpuid, prior revF of fam 0Fh, this reg is 0 */
> +	pci_read_config_dword(pdev, REG_CPUID, &cpuid);

I am just curious whether you have tested this on  a CPU revision prior revF.
Because "BIOS and Kernel Developer's Guide for AMD Athlon 64 and AMD
Opteron Processors" suggests that this register exists for those older CPUs:

"CPUID Fn[8000_0001,0000_0001]_EAX Family, Model, Feature Identifiers

 This register provides identical information to Function 3, Offset FCh."

(I don't have access to such a CPU model at the moment and thus can't
double-check this now.)


> +
> +	data->fam = (cpuid & 0x00000f00) >> 8;
> +	data->fam += (cpuid & 0x00f00000) >> 20;
> +
> +	switch (data->fam) {
> +		case 0xf:
> +			dev_warn(&pdev->dev, "Temperature readouts might be wrong"
> +						" - check errata #141\n");
> +	}
> +
>  	pci_read_config_byte(pdev, REG_TEMP, &scfg);
>  	scfg &= ~(SEL_PLACE | SEL_CORE);		/* Select sensor 0, core0 */
>  	pci_write_config_byte(pdev, REG_TEMP, scfg);

Regards,
Andreas




_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors