From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] cdrom: split mmc_ioctl to lower stack usage
Date: Tue, 18 Nov 2008 20:54:33 +0100 [thread overview]
Message-ID: <20081118195429.GA6010@joi> (raw)
In-Reply-To: <20081117121134.GM26778@kernel.dk>
On Mon, Nov 17, 2008 at 01:11:34PM +0100, Jens Axboe wrote:
> On Sun, Nov 16 2008, Marcin Slusarz wrote:
> > Checkstack output:
> >
> > Before:
> > mmc_ioctl: 584
> >
> > After:
> > mmc_ioctl_dvd_read_struct: 280
> > mmc_ioctl_cdrom_subchannel: 152
> > mmc_ioctl_cdrom_read_data: 120
> > mmc_ioctl_cdrom_volume: 104
> > mmc_ioctl_cdrom_read_audio: 104
> > (mmc_ioctl is inlined into cdrom_ioctl - 104 bytes)
>
> Looks good (both 1 and 2). What kind of testing have you done? I have
> applied it to for-2.6.29.
Only very basic testing - I can play audio cd's via amarok (CDROMREADRAW)
and kscd (CDROMREADAUDIO).
Marcin
prev parent reply other threads:[~2008-11-18 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-16 18:04 [PATCH 1/2] cdrom: split mmc_ioctl to lower stack usage Marcin Slusarz
2008-11-17 12:11 ` Jens Axboe
2008-11-18 19:54 ` Marcin Slusarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118195429.GA6010@joi \
--to=marcin.slusarz@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bzolnier@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.