All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH 0/0] ftrace updates to tip/core/urgent
Date: Wed, 19 Nov 2008 00:33:35 -0500	[thread overview]
Message-ID: <20081119053335.212100883@goodmis.org> (raw)

Ingo,

I ported the following patches to tip/core/urgent since they are candidates
for 2.6.28.

The first two are trivial, short, and should not be an issue. The first
two handle the printing of the set_ftrace_filter file correctly.

The third is a bigger patch "108 lines changed" and is actually a
clean up and fix.  The difference is that the current logic to
determine if a function should be enabled or not is incorrect.
With different combinations of using set_ftrace_filter and
set_ftrace_notrace, incorrect functions may be traced, or not traced.

But this bug that the patch fixes is not a critical bug. It should not
cause any stability problems with the kernel. The bug will only
produce undesirable traces.

But on the other hand, adding that last patch should not cause any
stability issues as well. And it makes the complex function cleaner
and more importantly, by coupling the ENABLED flag of the record
with the enabling (or disabling) of the tracing of the function
the record represents, makes the code more robust.


The following patches are in:

  git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git

      branch: tip/urgent


Steven Rostedt (3):
      ftrace: fix set_ftrace_filter
      ftrace: make filtered functions effective on setting
      ftrace: fix dyn ftrace filter selection

----
 kernel/trace/ftrace.c |  113 +++++++++++++++++++++++-------------------------
 1 files changed, 54 insertions(+), 59 deletions(-)

                 reply	other threads:[~2008-11-19  5:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081119053335.212100883@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.