From: Jarek Poplawski <jarkao2@gmail.com>
To: David Miller <davem@davemloft.net>, Jeff Garzik <jeff@garzik.org>
Cc: Ingo Molnar <mingo@elte.hu>,
Johannes Berg <johannes@sipsolutions.net>,
Ferenc Wagner <wferi@niif.hu>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] netconsole: Disable softirqs in write_msg()
Date: Wed, 19 Nov 2008 08:41:06 +0000 [thread overview]
Message-ID: <20081119084106.GA6699@ff.dom.local> (raw)
In-Reply-To: <87y6zwwy5c.fsf@tac.ki.iif.hu>
This report: http://marc.info/?l=linux-netdev&m=122599341430090&w=2
shows local_bh_enable() is used in the wrong context (irqs disabled).
It happens when a usual network path is called by netconsole, which
simply turns off hardirqs around this all.
This patch additionally disables softirqs to avoid possibility of
enabling bh and calling do_softirq() with hardirqs disabled.
Reported-by: Ferenc Wagner <wferi@niif.hu>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
---
drivers/net/netconsole.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index d304d38..f6ecad8 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -702,6 +702,8 @@ static void write_msg(struct console *con, const char *msg, unsigned int len)
if (list_empty(&target_list))
return;
+ /* Avoid enabling softirqs with hardirqs disabled */
+ local_bh_disable();
spin_lock_irqsave(&target_list_lock, flags);
list_for_each_entry(nt, &target_list, list) {
netconsole_target_get(nt);
@@ -723,6 +725,7 @@ static void write_msg(struct console *con, const char *msg, unsigned int len)
netconsole_target_put(nt);
}
spin_unlock_irqrestore(&target_list_lock, flags);
+ local_bh_enable();
}
static struct console netconsole = {
next prev parent reply other threads:[~2008-11-19 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 17:40 two warns on slowpath Ferenc Wagner
2008-11-17 13:35 ` [PATCH] softirq: Use local_irq_save() in local_bh_enable() Jarek Poplawski
2008-11-17 14:18 ` Johannes Berg
2008-11-18 7:49 ` Jarek Poplawski
2008-11-17 16:16 ` Ingo Molnar
2008-11-18 7:38 ` Jarek Poplawski
2008-11-19 8:41 ` Jarek Poplawski [this message]
2008-11-19 9:30 ` [PATCH] netconsole: Disable softirqs in write_msg() Ingo Molnar
2008-11-19 9:42 ` David Miller
2008-11-19 10:14 ` Ingo Molnar
2008-11-19 10:17 ` David Miller
2008-11-19 10:21 ` Ingo Molnar
2008-11-19 10:22 ` David Miller
2008-11-19 10:10 ` David Miller
2008-11-19 8:41 ` [PATCH] softirq: Fix warnings triggered by netconsole Jarek Poplawski
2008-11-19 9:32 ` Ingo Molnar
2008-11-19 11:07 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119084106.GA6699@ff.dom.local \
--to=jarkao2@gmail.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.