* [Patch] MODULE_UNLOAD should depend on PROC_FS
@ 2008-11-18 18:40 Américo Wang
2008-11-19 0:11 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Américo Wang @ 2008-11-18 18:40 UTC (permalink / raw)
To: LKML; +Cc: Rusty Russell, Andrew Morton
The feature controlled by MODULE_UNLOAD uses proc interface, so it
should depend on PROC_FS.
Signed-off-by: WANG Cong <wangcong@zeuux.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
---
diff --git a/init/Kconfig b/init/Kconfig
index 226da27..fade39e 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -871,6 +871,7 @@ config MODULE_FORCE_LOAD
config MODULE_UNLOAD
bool "Module unloading"
+ depends on PROC_FS
help
Without this option you will not be able to unload any
modules (note that some modules may not be unloadable
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Patch] MODULE_UNLOAD should depend on PROC_FS
2008-11-18 18:40 [Patch] MODULE_UNLOAD should depend on PROC_FS Américo Wang
@ 2008-11-19 0:11 ` Rusty Russell
2008-11-19 18:48 ` Américo Wang
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2008-11-19 0:11 UTC (permalink / raw)
To: Américo Wang; +Cc: LKML, Andrew Morton
On Wednesday 19 November 2008 05:10:52 Américo Wang wrote:
> The feature controlled by MODULE_UNLOAD uses proc interface, so it
> should depend on PROC_FS.
Hi Wang,
This patch looks wrong to me; you can remove modules without /proc. Does
it not compile with CONFIG_MODULE_UNLOAD=y and CONFIG_PROC_FS=n?
Thanks,
Rusty.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch] MODULE_UNLOAD should depend on PROC_FS
2008-11-19 0:11 ` Rusty Russell
@ 2008-11-19 18:48 ` Américo Wang
0 siblings, 0 replies; 3+ messages in thread
From: Américo Wang @ 2008-11-19 18:48 UTC (permalink / raw)
To: Rusty Russell; +Cc: LKML, Andrew Morton
On Wed, Nov 19, 2008 at 10:41:53AM +1030, Rusty Russell wrote:
>On Wednesday 19 November 2008 05:10:52 Américo Wang wrote:
>> The feature controlled by MODULE_UNLOAD uses proc interface, so it
>> should depend on PROC_FS.
>
>Hi Wang,
>
> This patch looks wrong to me; you can remove modules without /proc. Does
>it not compile with CONFIG_MODULE_UNLOAD=y and CONFIG_PROC_FS=n?
>
Thank you, Rusty and Alan!
I think I was wrong. It is compiled fine with the above config, just tested.
--
"Sometimes the only way to stay sane is to go a little crazy."
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-19 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-18 18:40 [Patch] MODULE_UNLOAD should depend on PROC_FS Américo Wang
2008-11-19 0:11 ` Rusty Russell
2008-11-19 18:48 ` Américo Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.