From: Pavel Machek <pavel@suse.cz>
To: Christoph Hellwig <hch@infradead.org>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>,
kaszak@gmail.com, lcostantino@gmail.com,
linux-wireless@vger.kernel.org
Subject: Re: w35und wifi driver for linux-staging
Date: Wed, 19 Nov 2008 12:28:23 +0100 [thread overview]
Message-ID: <20081119112823.GD21876@elf.ucw.cz> (raw)
In-Reply-To: <20081001125248.GA29661@infradead.org>
On Wed 2008-10-01 08:52:48, Christoph Hellwig wrote:
> On Wed, Oct 01, 2008 at 02:36:56PM +0200, Pavel Machek wrote:
> > +source "drivers/net/wireless/winbond/Kconfig"
>
> winbond is a little too generic, please use the same name as the driver
> name for the directory.
>
> > @@ -0,0 +1,6 @@
> > +config W35UND
> > + tristate "Winbond driver"
> > + depends on MAC80211 && WLAN_80211 && EXPERIMENTAL && !4KSTACKS
> > + ---help---
> > + This is highly experimental driver for winbond wifi card on some Kohjinsha notebooks
> > + Check http://code.google.com/p/winbondport/ for new version
>
> Again, please give the option a useful name, and a useful description
> including mentioning the actual chip name in there.
>
> Also the !4KSTACKS dependency looks rather odd.
Fixed now, will sent patch shortly.
> No comments on the code now, I don't think I want to look at it..
No, you don't want to :-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-11-19 18:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-01 12:36 w35und wifi driver for linux-staging Pavel Machek
2008-10-01 12:36 ` Pavel Machek
2008-10-01 11:34 ` Luis R. Rodriguez
2008-10-01 18:53 ` Greg KH
2008-10-01 12:52 ` Christoph Hellwig
2008-10-02 19:12 ` Dan Williams
2008-11-19 11:28 ` Pavel Machek [this message]
2008-10-01 19:39 ` patch staging-add-w35und-wifi-driver.patch added to gregkh-2.6 tree gregkh
2008-10-01 23:05 ` Ian Schram
2008-10-01 23:10 ` Greg KH
2008-11-24 8:49 ` Pavel Machek
2008-10-02 9:57 ` Pavel Machek
2008-10-18 21:19 ` w35und wifi driver for linux-staging Arjan van de Ven
2008-10-20 16:57 ` Dan Williams
2008-10-20 17:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119112823.GD21876@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=greg@kroah.com \
--cc=hch@infradead.org \
--cc=kaszak@gmail.com \
--cc=lcostantino@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.