From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Wed, 19 Nov 2008 14:22:30 +0100 Subject: [U-Boot] [PATCH] Fix FDT support to use fdt blob and FIT together or not In-Reply-To: <20081119131059.E0393832E89D@gemini.denx.de> References: <1226968111-965-1-git-send-email-plagnioj@jcrosoft.com> <1227053359-8452-1-git-send-email-plagnioj@jcrosoft.com> <20081119114417.D9637832E89D@gemini.denx.de> <20081119121016.GB30468@game.jcrosoft.org> <20081119131059.E0393832E89D@gemini.denx.de> Message-ID: <20081119132230.GA1051@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 14:10 Wed 19 Nov , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20081119121016.GB30468@game.jcrosoft.org> you wrote: > > > > > > +#if defined(CONFIG_PPC) || defined(CONFIG_M68K) > > > > > > Maybe "|| defined(CONFIG_SPARC)" is missing here? > > no this function is only use on PPC and M68K bootm > > Then, again, we should add a feature-specific #define here, but not an > architecture specific one. I'll think of 2 new CONFIG so > > > > > -COBJS-$(CONFIG_OF_LIBFDT) += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o > > > > +COBJS-libfdt += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o > > > > + > > > > +COBJS-$(CONFIG_OF_LIBFDT) += $(COBJS-libfdt) > > > > +COBJS-$(CONFIG_FIT) += $(COBJS-libfdt) > > > > + > > > > > > Would it not be easier to just add a line > > > > > > COBJS-$(CONFIG_FIT) += fdt.o fdt_ro.o fdt_rw.o fdt_strerror.o fdt_sw.o fdt_wip.o > > > > > > ? > > no because we may do not have the CONFIG_OF_LIBFDT and CONFIG_FIT at the same > > time > > Yes, of course we may have both at the same time. with my modification I'd like to support the 3 following configurations : 1) FIT only CONFIG_FIT 2) fdt blob only CONFIG_OF_LIBFDT 3) both CONFIG_OF_LIBFDT & CONFIG_FIT so CONFIG_FIT could have CONFIG_FIT without CONFIG_OF_LIBFDT Best Regards, J.