From: Greg KH <gregkh@suse.de>
To: crquan@gmail.com
Cc: Jens Axboe <jens.axboe@oracle.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kobject_add: use constant strings directly as fmt strings
Date: Wed, 19 Nov 2008 07:57:36 -0800 [thread overview]
Message-ID: <20081119155736.GA5072@suse.de> (raw)
In-Reply-To: <1227110059-12529-1-git-send-email-crquan@gmail.com>
On Wed, Nov 19, 2008 at 11:54:19PM +0800, crquan@gmail.com wrote:
> From: Cheng Renquan <crquan@gmail.com>
>
> Signed-off-by: Cheng Renquan <crquan@gmail.com>
> ---
> block/blk-sysfs.c | 2 +-
> block/elevator.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
> index 21e275d..0b189e9 100644
> --- a/block/blk-sysfs.c
> +++ b/block/blk-sysfs.c
> @@ -342,7 +342,7 @@ int blk_register_queue(struct gendisk *disk)
> return 0;
>
> ret = kobject_add(&q->kobj, kobject_get(&disk_to_dev(disk)->kobj),
> - "%s", "queue");
> + "queue");
Why? What does this change buy us?
thanks,
greg k-h
next prev parent reply other threads:[~2008-11-19 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 15:54 [PATCH] kobject_add: use constant strings directly as fmt strings crquan
2008-11-19 15:57 ` Greg KH [this message]
2008-11-19 16:17 ` rae l
2008-11-19 17:00 ` Kay Sievers
2008-11-19 17:37 ` rae l
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081119155736.GA5072@suse.de \
--to=gregkh@suse.de \
--cc=crquan@gmail.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.