From: Jeremy Higdon <jeremy@sgi.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Sergei Shtylylov <sshtylyov@ru.mvista.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] sgiioc4: sgiioc4_read_status drive busy check fix
Date: Thu, 20 Nov 2008 01:43:46 -0800 [thread overview]
Message-ID: <20081120094346.GL262904@sgi.com> (raw)
In-Reply-To: <200810031849.11365.bzolnier@gmail.com>
On Fri, Oct 03, 2008 at 06:49:10PM +0200, Bartlomiej Zolnierkiewicz wrote:
> On Sunday 28 September 2008, Sergei Shtylylov wrote:
> > Fix the drive non-busy criterion used by sgiioc4_read_status(): neither of the
> > bits it expects to be set guarantees that the drive is not busy (and might be
> > interrupting), only the BSY bit itself being zero gurantees that.
> > While at it, use ATA_BUSY instead of hardcoded value everywhere...
> >
> > Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> applied patches #1-2
I finally got around to trying these patches, and they work fine. Thanks
for the cleanups, Sergei!
Acked-by: Jeremy Higdon <jeremy@sgi.com>
prev parent reply other threads:[~2008-11-20 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-28 19:48 [PATCH 1/2] sgiioc4: sgiioc4_read_status drive busy check fix Sergei Shtylylov
2008-10-03 16:49 ` Bartlomiej Zolnierkiewicz
2008-11-20 9:43 ` Jeremy Higdon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120094346.GL262904@sgi.com \
--to=jeremy@sgi.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.