From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: balbir@linux.vnet.ibm.com, dhaval@linux.vnet.ibm.com,
kamezawa.hiroyu@jp.fujitsu.com, lizf@cn.fujitsu.com,
menage@google.com, rientjes@google.com, xemul@openvz.org,
yamamoto@valinux.co.jp
Subject: + memory-cgroup-hierarchy-feature-selector-v4-fix.patch added to -mm tree
Date: Thu, 20 Nov 2008 13:45:51 -0800 [thread overview]
Message-ID: <200811202145.mAKLjpPL007690@imap1.linux-foundation.org> (raw)
The patch titled
Memory cgroup fix hierarchy selector
has been added to the -mm tree. Its filename is
memory-cgroup-hierarchy-feature-selector-v4-fix.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this
The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
------------------------------------------------------
Subject: Memory cgroup fix hierarchy selector
From: Balbir Singh <balbir@linux.vnet.ibm.com>
Andrew and Li reviewed and found that we need to check for val being 1 or
0 for the root container as well. use_hierarchy's type is changed to
bool. We still continue to use the ease of write_X64 for writing to it
and then check if the values are sane.
Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
Cc: YAMAMOTO Takashi <yamamoto@valinux.co.jp>
Cc: Paul Menage <menage@google.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: David Rientjes <rientjes@google.com>
Cc: Pavel Emelianov <xemul@openvz.org>
Cc: Dhaval Giani <dhaval@linux.vnet.ibm.com>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/memcontrol.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff -puN mm/memcontrol.c~memory-cgroup-hierarchy-feature-selector-v4-fix mm/memcontrol.c
--- a/mm/memcontrol.c~memory-cgroup-hierarchy-feature-selector-v4-fix
+++ a/mm/memcontrol.c
@@ -152,7 +152,7 @@ struct mem_cgroup {
/*
* Should the accounting and control be hierarchical, per subtree?
*/
- unsigned long use_hierarchy;
+ bool use_hierarchy;
int obsolete;
atomic_t refcnt;
@@ -1567,8 +1567,8 @@ static int mem_cgroup_hierarchy_write(st
* For the root cgroup, parent_mem is NULL, we allow value to be
* set if there are no children.
*/
- if (!parent_mem || (!parent_mem->use_hierarchy &&
- (val == 1 || val == 0))) {
+ if ((!parent_mem || !parent_mem->use_hierarchy) &&
+ (val == 1 || val == 0)) {
if (list_empty(&cont->children))
mem->use_hierarchy = val;
else
_
Patches currently in -mm which might be from balbir@linux.vnet.ibm.com are
origin.patch
linux-next.patch
memcg-swap-cgroup-for-remembering-usage-fix-2.patch
memcg-swap-cgroup-for-remembering-usage-fix-3.patch
memcg-swap-cgroup-for-remembering-usage-fix-4.patch
memory-cgroup-hierarchy-documentation-v4.patch
memory-cgroup-resource-counters-for-hierarchy-v4.patch
memory-cgroup-resource-counters-for-hierarchy-v4-checkpatch-fixes.patch
memory-cgroup-hierarchical-reclaim-v4.patch
memory-cgroup-hierarchical-reclaim-v4-checkpatch-fixes.patch
memory-cgroup-hierarchy-feature-selector-v4.patch
memory-cgroup-hierarchy-feature-selector-v4-fix.patch
reply other threads:[~2008-11-20 21:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811202145.mAKLjpPL007690@imap1.linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=dhaval@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=mm-commits@vger.kernel.org \
--cc=rientjes@google.com \
--cc=xemul@openvz.org \
--cc=yamamoto@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.