From: Ingo Molnar <mingo@elte.hu>
To: eranian@gmail.com
Cc: Markus Metzger <markus.t.metzger@googlemail.com>,
lkml <linux-kernel@vger.kernel.org>,
work <markus.t.metzger@intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [patch] x86, bts: fix unlock problem in ds.c
Date: Thu, 20 Nov 2008 22:48:05 +0100 [thread overview]
Message-ID: <20081120214805.GA8475@elte.hu> (raw)
In-Reply-To: <7c86c4470811201314q564b64c0i99f3d9865d9cc8f0@mail.gmail.com>
* stephane eranian <eranian@googlemail.com> wrote:
> Markus,
>
> I think this patch is not quite right. You don't want to go out via
> out_unlock because you're going to call ds_put_context)() when you
> did not invoke the matching ds_get_context() (hidden in
> ds_alloc_context). It happens later in the ds_request() function.
i noticed that, and fixed it via:
10db4ef: x86, PEBS/DS: fix code flow in ds_request()
can you still see problems with it?
Ingo
next prev parent reply other threads:[~2008-11-20 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 10:00 [patch] x86, bts: fix unlock problem in ds.c Markus Metzger
2008-11-16 7:26 ` Ingo Molnar
2008-11-20 21:14 ` stephane eranian
2008-11-20 21:48 ` Ingo Molnar [this message]
2008-11-20 22:06 ` stephane eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120214805.GA8475@elte.hu \
--to=mingo@elte.hu \
--cc=eranian@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@googlemail.com \
--cc=markus.t.metzger@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.