From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Steve Sakoman <sakoman@gmail.com>
Cc: ext naveen krishna ch <naveenkrishna.ch@gmail.com>,
alsa-devel@alsa-project.org, Mark Brown <broonie@sirena.org.uk>,
Steve Sakoman <steve@sakoman.com>
Subject: Re: twl4030 asoc kcontrols and widgets
Date: Fri, 21 Nov 2008 11:49:03 +0200 [thread overview]
Message-ID: <200811211149.03905.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <5e088bd90811200739x537252efx94e3fbe4e2303180@mail.gmail.com>
Hi,
Sorry about the delayed reply...
On Thursday 20 November 2008 17:39:14 ext Steve Sakoman wrote:
>
> Agreed! This is a really good thing to do.
>
> Had I not been under a lot of time pressure when doing the original
> version of the driver I would have taken this approach myself.
>
> I'm glad to see that you are tackling this. Peter, you should post
> your patches for comment. Might help speed things along if we get
> more folks looking and contributing.
>
> Steve
>
I'm planing to send patches as soon as possible.
I have been working with the twl4030 codec for about a week now, so the
thing that I have is far from what it should be at the end...
I can explain in short what I have at the moment and what is missing:
- Playback route controls for:
- PreDriveL (Off, Voice, DACL1, DACL2, DACR2)
- PreDriveR (Off, Voice, DACR1, DACR2, DACL2)
- HeadsetL (Off, Voice, DACL1, DACL2)
- HeadsetR (Off, Voice, DACR1, DACR2)
- CarkitL (Off, Voice, DACL1, DACL2) # or PRECKT_Right
- CarkitR (Off, Voice, DACR1, DACR2) # or PRECKT_Left
- HandsfreeL (Voice, DACL1, DACL2, DACR2) # or IHFL or Class-DL
# (depends which text I take)
- HandsfreeR (Voice, DACR1, DACR2, DACL2) # or IHFR or Class-DR
# (depends which text I take)
Volume/Gain controls:
- FGAIN in DAC2 (mute, -62 - 0 dB, in 1 dB steps)
- CGAIN in DAC2 (0 - 12 dB, in 6 dB steps)
- PreDrive(L and R, not separate) playback gain,
or volume control (mute, -6, 0, 6 dB)
- Headset(L and R, not separate) playback gain,
or volume control (mute, -6, 0, 6 dB)
- Carkit(L and R, not separate) playback gain,
or volume control (mute, -6, 0, 6 dB)
All of the above are added to the twl4030_snd_controls at this
point of time.
The twl4030_reg has been set to disable all outputs by
default, it is up to the user to enable the needed outputs.
SND_SOC_DAPM_INPUT() and SND_SOC_DAPM_OUTPUT() definitions for
all physical inputs, outputs.
I have not yet started with the correct dapm_route for the TWL,
it is going to be quite a mess.
At the moment outputs are connected to DACL/R2, for example:
{"PREDRIVL", NULL, "DACL2"}
So in the playback side what you can do already:
You can select the routing individually for all outputs (except the
Earpiece, hmm I forgot about it).
The capture path is kind of untouched, it is in the to-do list, it does
works with the DIGIMIC0 for me.
Three sets of get/put function for dealing with TWL's specially crafted
registers (Routing selections, Gain controls).
What needs to be done:
Lot's of things...
Clean up?
snd_soc_dapm_route, snd_soc_dapm_widget things (I need an A3 paper for that).
Capture controls and corresponding dapm_route, dapm_widgets
So this is my current status, are you still interested to see these things?
What else should I add before I send the patch?
--
Péter
next prev parent reply other threads:[~2008-11-21 9:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 9:38 twl4030 asoc kcontrols and widgets naveen krishna ch
2008-11-20 10:52 ` Mark Brown
2008-11-20 14:02 ` Peter Ujfalusi
2008-11-20 14:14 ` Mark Brown
2008-11-20 15:39 ` Steve Sakoman
2008-11-21 9:49 ` Peter Ujfalusi [this message]
2008-11-21 15:49 ` Mark Brown
2008-11-20 14:17 ` naveen krishna ch
[not found] <ef0d8a250811200202o5852dabct8c5b135b86141f67@mail.gmail.com>
2008-11-20 10:55 ` TWL4030 " Felipe Balbi
2008-11-20 17:32 ` Tony Lindgren
2008-11-20 17:42 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811211149.03905.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=naveenkrishna.ch@gmail.com \
--cc=sakoman@gmail.com \
--cc=steve@sakoman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.