From: Andrew Morton <akpm@linux-foundation.org>
To: Keika Kobayashi <kobayashi.kk@ncos.nec.co.jp>
Cc: linux-kernel@vger.kernel.org, h-shimamoto@ct.jp.nec.com,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH 2/3] proc: Export statistics for softirq to /proc
Date: Fri, 21 Nov 2008 17:35:18 -0800 [thread overview]
Message-ID: <20081121173518.5ffe3a9e.akpm@linux-foundation.org> (raw)
In-Reply-To: <20081121170743.cd30b01e.kobayashi.kk@ncos.nec.co.jp>
On Fri, 21 Nov 2008 17:07:43 -0800 Keika Kobayashi <kobayashi.kk@ncos.nec.co.jp> wrote:
> > This uses for_each_online_cpu(), but below we use for_each_possible_cpu().
> >
> > Shouldn't we be consistent here so that at least the numbers will add
> > up to the same thing?
> >
> > Probably for_each_possible_cpu() is best - people might want to see how
> > many softirqs happened on a CPU which was recently offlined.
>
> I understand this point. I'll fix it later.
>
> There is same problem regarding /proc/interrupts.
> Should we change from for_each_online_cpu() to for_each_possible_cpu(),
> or is it too late?
I assume that /proc/interrupts has been that way for a very long time,
and nobody has noticed&complained. If we can find anyone who actually
uses cpu hotplug then perhaps they could help us out here. But such
people seem to be rare.
I dunno. I guess we can leave /proc/interrupts alone.
next prev parent reply other threads:[~2008-11-22 1:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 3:55 [PATCH 1/3] softirq: Introduce statistics for softirq Keika Kobayashi
2008-11-21 3:58 ` [PATCH 2/3] proc: Export statistics for softirq to /proc Keika Kobayashi
2008-11-21 4:16 ` Alexey Dobriyan
2008-11-21 4:21 ` Randy Dunlap
2008-11-21 5:09 ` Andrew Morton
2008-11-21 18:06 ` Keika Kobayashi
2008-11-22 1:07 ` Keika Kobayashi
2008-11-22 1:35 ` Andrew Morton [this message]
2008-11-21 4:01 ` [PATCH 3/3] proc: Update document for /proc/softirqs and /proc/stat Keika Kobayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081121173518.5ffe3a9e.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=kobayashi.kk@ncos.nec.co.jp \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.