From: Felipe Balbi <me@felipebalbi.com>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 2/3] omap mailbox: add initial omap3 support
Date: Sat, 22 Nov 2008 13:57:47 +0200 [thread overview]
Message-ID: <20081122115746.GC6289@frodo> (raw)
In-Reply-To: <1227313717-26399-2-git-send-email-Hiroshi.DOYU@nokia.com>
On Sat, Nov 22, 2008 at 02:28:36AM +0200, Hiroshi DOYU wrote:
> @@ -30,7 +30,7 @@
> #define MAILBOX_IRQ_NEWMSG(u) (1 << (2 * (u)))
> #define MAILBOX_IRQ_NOTFULL(u) (1 << (2 * (u) + 1))
>
> -static unsigned long mbox_base;
> +static void __iomem *mbox_base;
ohh. you did :-) forget my previous comment
--
balbi
next prev parent reply other threads:[~2008-11-22 11:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-22 0:28 [PATCH 1/3] omap mailbox: cleanup register definition with macro Hiroshi DOYU
2008-11-22 0:28 ` [PATCH 2/3] omap mailbox: add initial omap3 support Hiroshi DOYU
2008-11-22 0:28 ` [PATCH 3/3] omap mailbox: print hardware revision Hiroshi DOYU
2008-11-22 11:57 ` Felipe Balbi [this message]
2008-11-22 21:09 ` [PATCH 2/3] omap mailbox: add initial omap3 support Hiroshi DOYU
2008-11-22 11:55 ` [PATCH 1/3] omap mailbox: cleanup register definition with macro Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081122115746.GC6289@frodo \
--to=me@felipebalbi.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.