All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: Warren Turkal <wt@penguintechs.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] Fix journal detection on HFS+.
Date: Sun, 23 Nov 2008 05:52:00 +0100	[thread overview]
Message-ID: <200811230552.02221.zippel@linux-m68k.org> (raw)
In-Reply-To: <1227240087-29413-3-git-send-email-wt@penguintechs.org>

Hi,

On Friday 21. November 2008, Warren Turkal wrote:

(Sorry for taking so long to get to this.)

> +static bool hfsplus_vol_has_journal(struct hfsplus_vh *vhdr)
> +{
> +	return (vhdr->attributes & cpu_to_be32(HFSPLUS_VOL_JOURNALED) &&
> +				vhdr->journal_info_block);
> +}

I'm curious how common it is to have the journal bit set but no journal block, 
I haven't seen this case so far.
IMO more useful would be to read the journal block and check if there is 
anything that needs to be replayed.
If you're interested in a second step you could replay the journal, it's not 
that difficult to do, it's pretty much just copying blocks around.

bye, Roman

  reply	other threads:[~2008-11-23  4:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21  4:01 [PATCH 0/2] HFS+ journal improvement - take 6 Warren Turkal
2008-11-21  4:01 ` [PATCH 1/2] Identify journal info block in volume header Warren Turkal
2008-11-21  4:01   ` [PATCH 2/2] Fix journal detection on HFS+ Warren Turkal
2008-11-23  4:52     ` Roman Zippel [this message]
2008-11-25 23:45       ` Warren Turkal
2008-11-27 16:21         ` Roman Zippel
2008-12-01 10:28           ` Warren Turkal
2008-12-01 14:27             ` Roman Zippel
2008-12-01 14:49             ` Roman Zippel
  -- strict thread matches above, loose matches on Subject: below --
2008-11-20  2:25 [PATCH 0/2] HFS+ journal improvement - take 5 Warren Turkal
2008-11-20  2:25 ` [PATCH 1/2] Identify journal info block in volume header Warren Turkal
2008-11-20  2:26   ` [PATCH 2/2] Fix journal detection on HFS+ Warren Turkal
2008-11-20 11:29     ` Jörn Engel
2008-11-20 17:02       ` Warren Turkal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811230552.02221.zippel@linux-m68k.org \
    --to=zippel@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=wt@penguintechs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.