All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Webb <chris@arachsys.com>
To: qemu-devel@nongnu.org
Cc: kvm@vger.kernel.org
Subject: [PATCH] Fix off-by-one bug limiting VNC passwords to 7 chars
Date: Sun, 23 Nov 2008 11:31:47 +0000	[thread overview]
Message-ID: <20081123113147.GA12832@arachsys.com> (raw)

Fix off-by-one bug limiting VNC passwords to 7 characters instead of 8

monitor_readline expects buf_size to include the terminating \0, but
do_change_vnc in monitor.c calls it as though it doesn't. The other site
where monitor_readline reads a password (in vl.c) passes the buffer length
correctly.

Signed-off-by: Chris Webb <chris@arachsys.com>
---
 monitor.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor.c b/monitor.c
index 22360fc..6ae5729 100644
--- a/monitor.c
+++ b/monitor.c
@@ -433,7 +433,7 @@ static void do_change_vnc(const char *target)
     if (strcmp(target, "passwd") == 0 ||
 	strcmp(target, "password") == 0) {
 	char password[9];
-	monitor_readline("Password: ", 1, password, sizeof(password)-1);
+	monitor_readline("Password: ", 1, password, sizeof(password));
 	password[sizeof(password)-1] = '\0';
 	if (vnc_display_password(NULL, password) < 0)
 	    term_printf("could not set VNC server password\n");

             reply	other threads:[~2008-11-23 11:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-23 11:31 Chris Webb [this message]
2008-11-23 12:31 ` [PATCH] Fix off-by-one bug limiting VNC passwords to 7 chars Thiemo Seufer
2008-11-25 10:09   ` [Qemu-devel] " Chris Webb
2008-11-25 10:25     ` [PATCH v2] " Chris Webb
2008-11-25 10:26       ` [PATCH v2] Accept password as an argument to 'change vnc password' Chris Webb
2008-12-08 14:09       ` [RESEND] " Chris Webb
2008-12-10 15:14         ` Anthony Liguori
2008-12-08 14:09     ` [RESEND] [PATCH v2] Fix off-by-one bug limiting VNC passwords to 7 chars Chris Webb
2008-12-10 15:14       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081123113147.GA12832@arachsys.com \
    --to=chris@arachsys.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.