All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Alexander van Heukelum <heukelum@mailshack.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC -tip] x86: introduce X86_ assembly names macros to catch unbalanced declaration
Date: Sun, 23 Nov 2008 19:27:28 +0300	[thread overview]
Message-ID: <20081123162728.GF27396@localhost> (raw)
In-Reply-To: <20081123162257.GB570@elte.hu>

[Ingo Molnar - Sun, Nov 23, 2008 at 05:22:57PM +0100]
| 
| * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
| 
| > It's usefull to catch unbalanced or messed declarations of ENTRY and
| > KPROBES. These macros would help a bit (at least I hope so).
| > 
| > For example the following code would compile without problems
| > 
| > 	X86_ENTRY(mcount)
| > 		retq
| > 	X86_END(mcount)
| > 
| > But if you forget and mess the following form
| > 
| > 	X86_ENTRY(mcount)
| > 		retq
| > 	END(mcount)
| > 
| > 	X86_ENTRY(ftrace_caller)
| > 
| > The assembler will issue the following message:
| > Error: X86_ENTRY/KPROBE unbalanced or missed
| 
| looks good - a very small detail: i'd suggest ENTRY_X86()/END_X86() - 
| because whoever is reading this portion of the code is amply aware of 
| the fact that this is the x86 tree - so the more important information 
| should come first.
| 
| 	Ingo
| 

Will fix shortly :)

		- Cyrill -

      reply	other threads:[~2008-11-23 16:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-23 16:14 [RFC -tip] x86: introduce X86_ assembly names macros to catch unbalanced declaration Cyrill Gorcunov
2008-11-23 16:22 ` Ingo Molnar
2008-11-23 16:27   ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081123162728.GF27396@localhost \
    --to=gorcunov@gmail.com \
    --cc=heukelum@mailshack.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.