All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: brice@myri.com
Cc: jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] myri10ge: fix indentation
Date: Mon, 24 Nov 2008 14:43:57 -0800 (PST)	[thread overview]
Message-ID: <20081124.144357.65741555.davem@davemloft.net> (raw)
In-Reply-To: <49295DFD.9050609@myri.com>

From: Brice Goglin <brice@myri.com>
Date: Sun, 23 Nov 2008 14:43:25 +0100

> Bring the indentation in line with the output of the Lindent script.
> 
> Signed-off-by: Brice Goglin <brice@myri.com>

Please don't blindly apply tools like this.

>  static const struct net_device_ops myri10ge_netdev_ops = {
> -	.ndo_open		= myri10ge_open,
> -	.ndo_stop		= myri10ge_close,
> -	.ndo_start_xmit		= myri10ge_xmit,
> -	.ndo_get_stats		= myri10ge_get_stats,
> -	.ndo_validate_addr	= eth_validate_addr,
> -	.ndo_change_mtu		= myri10ge_change_mtu,
> +	.ndo_open = myri10ge_open,
> +	.ndo_stop = myri10ge_close,
> +	.ndo_start_xmit = myri10ge_xmit,
> +	.ndo_get_stats = myri10ge_get_stats,
> +	.ndo_validate_addr = eth_validate_addr,
> +	.ndo_change_mtu = myri10ge_change_mtu,
>  	.ndo_set_multicast_list = myri10ge_set_multicast_list,
> -	.ndo_set_mac_address	= myri10ge_set_mac_address,
> +	.ndo_set_mac_address = myri10ge_set_mac_address,
>  };
>  

I specifically used tabs here when applying this, on the left side of
the equal sign, in order to line everything up nicely.  And now this
patch is undoing that.

Patch not applied.

  reply	other threads:[~2008-11-24 22:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-23 13:43 [PATCH net-next] myri10ge: fix indentation Brice Goglin
2008-11-24 22:43 ` David Miller [this message]
2008-11-24 22:52   ` Brice Goglin
2008-11-24 22:55     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081124.144357.65741555.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=brice@myri.com \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.