From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 10/10] tcp: handle shift/merge of cloned skbs too
Date: Mon, 24 Nov 2008 21:32:02 -0800 (PST) [thread overview]
Message-ID: <20081124.213202.09724181.davem@davemloft.net> (raw)
In-Reply-To: <1227536527-29713-11-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 24 Nov 2008 16:22:07 +0200
> This caused me to get repeatably:
>
> tcpdump: pcap_loop: recvfrom: Bad address
>
> Happens occassionally when I tcpdump my for-looped test xfers:
> while [ : ]; do echo -n "$(date '+%s.%N') "; ./sendfile; sleep 20; done
>
> Rest of the relevant commands:
> ethtool -K eth0 tso off
> tc qdisc add dev eth0 root netem drop 4%
> tcpdump -n -s0 -i eth0 -w sacklog.all
I'm applying this in any event.
What could be happening is some bad clone handling
elsewhere (AF_PACKET, for example) and thus for some
reason libpcap reads stale data then performs a packet
read using incorrect lengths and this leads to reading
past the end of it's user buffer and we -EFAULT.
Just capturing the -EFAULT'ing call arguments with strace
would be enough to give some deeper clues. Do you have
that?
next prev parent reply other threads:[~2008-11-25 5:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 14:21 [PATCH 0/n]: 2 is better than 1 - tcp recombining; both with SACK and rexmits Ilpo Järvinen
2008-11-24 14:21 ` [PATCH 01/10] tcp: collapse more than two on retransmission Ilpo Järvinen
2008-11-24 14:21 ` [PATCH 02/10] tcp: move tcp_simple_retransmit to tcp_input Ilpo Järvinen
2008-11-24 14:22 ` [PATCH 03/10] tcp: more aggressive skipping Ilpo Järvinen
2008-11-24 14:22 ` [PATCH 04/10] tcp: Make SACK code to split only at mss boundaries Ilpo Järvinen
2008-11-24 14:22 ` [PATCH 05/10] tcp: make tcp_sacktag_one able to handle partial skb too Ilpo Järvinen
2008-11-24 14:22 ` [PATCH 06/10] tcp: Try to restore large SKBs while SACK processing Ilpo Järvinen
2008-11-24 14:22 ` [PATCH 07/10] tcp: Make shifting not clear the hints Ilpo Järvinen
2008-11-24 14:22 ` [PATCH 08/10] tcp: add some mibs to track collapsing Ilpo Järvinen
2008-11-24 14:22 ` [PATCH 09/10] tcp: more accurate fallback counters (DEBUGONLY) Ilpo Järvinen
2008-11-24 14:22 ` [PATCH 10/10] tcp: handle shift/merge of cloned skbs too Ilpo Järvinen
2008-11-25 5:32 ` David Miller [this message]
2008-11-25 5:27 ` [PATCH 09/10] tcp: more accurate fallback counters (DEBUGONLY) David Miller
2008-11-25 5:27 ` [PATCH 08/10] tcp: add some mibs to track collapsing David Miller
2008-11-25 5:27 ` [PATCH 07/10] tcp: Make shifting not clear the hints David Miller
2008-11-25 5:20 ` [PATCH 06/10] tcp: Try to restore large SKBs while SACK processing David Miller
2008-11-25 5:15 ` [PATCH 05/10] tcp: make tcp_sacktag_one able to handle partial skb too David Miller
2008-11-25 13:44 ` Ilpo Järvinen
2008-11-25 5:13 ` [PATCH 04/10] tcp: Make SACK code to split only at mss boundaries David Miller
2008-11-25 5:12 ` [PATCH 03/10] tcp: more aggressive skipping David Miller
2008-11-24 14:50 ` [PATCH 02/10] tcp: move tcp_simple_retransmit to tcp_input Ilpo Järvinen
2008-11-24 16:36 ` Andi Kleen
2008-11-24 16:58 ` Ilpo Järvinen
2008-11-24 19:07 ` Andi Kleen
2008-11-25 5:10 ` David Miller
2008-11-25 14:02 ` Ilpo Järvinen
2008-11-25 21:45 ` David Miller
2008-11-25 5:05 ` [PATCH 01/10] tcp: collapse more than two on retransmission David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124.213202.09724181.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.