From: Theodore Tso <tytso@MIT.EDU>
To: Andreas Dilger <adilger@sun.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Coly Li <coyli@suse.de>,
cmm@us.ibm.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH -V2 4/5] ext4: Use both hi and lo bits of the group desc values.
Date: Sun, 23 Nov 2008 20:21:13 -0500 [thread overview]
Message-ID: <20081124012113.GA2163@mit.edu> (raw)
In-Reply-To: <20081123040939.GU3186@webber.adilger.int>
On Sat, Nov 22, 2008 at 10:09:39PM -0600, Andreas Dilger wrote:
> On Nov 21, 2008 11:53 -0600, Eric Sandeen wrote:
> > Ok, and for the rest? (free_blocks, free_inodes) - I guess these are
> > only needed for > 2^32 block filesystems?
>
> Actually, since this is a per-group number, I'm not sure why this is
> needed at all. I don't object to keeping the helper functions though.
For most systems, it wn't be needed at all. However, for filesystems
with block sizes >= 8k, we run into a limit where the maximum number
of blocks and inodes we can support per block group is 65528 (we can't
support 65536 since that would cause bg_free_blocks_count and/or
bg_free_blocks_count, which are both __u16 types, to overflow). So on
systems with a page size > 4k, or if Christoph's patch to support fs
block sizes > page size ever makes it into mainline, this support
could be useful.
- Ted
next prev parent reply other threads:[~2008-11-24 1:26 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 16:44 [PATCH -V2 1/5] ext4: Remove unneeded code Aneesh Kumar K.V
2008-11-21 16:44 ` [PATCH -V2 2/5] ext4: unlock group before ext4_error Aneesh Kumar K.V
2008-11-21 16:44 ` [PATCH -V2 3/5] ext4: Fix the race between read_block_bitmap and mark_diskspace_used Aneesh Kumar K.V
2008-11-21 16:44 ` [PATCH -V2 4/5] ext4: Use both hi and lo bits of the group desc values Aneesh Kumar K.V
2008-11-21 16:44 ` [PATCH -V2 5/5] ext4: Fix the race between read_inode_bitmap and ext4_new_inode Aneesh Kumar K.V
2008-11-21 17:30 ` Eric Sandeen
2008-11-23 19:26 ` Theodore Tso
2008-11-24 4:05 ` Theodore Tso
2008-11-24 11:15 ` Aneesh Kumar K.V
2008-11-21 17:29 ` [PATCH -V2 4/5] ext4: Use both hi and lo bits of the group desc values Eric Sandeen
2008-11-21 17:41 ` Aneesh Kumar K.V
2008-11-21 17:53 ` Eric Sandeen
2008-11-23 4:09 ` Andreas Dilger
2008-11-24 1:21 ` Theodore Tso [this message]
2008-11-24 2:13 ` Theodore Tso
2008-11-24 10:38 ` Aneesh Kumar K.V
2008-11-21 17:22 ` [PATCH -V2 3/5] ext4: Fix the race between read_block_bitmap and mark_diskspace_used Eric Sandeen
2008-11-21 17:31 ` Aneesh Kumar K.V
2008-11-21 17:39 ` Aneesh Kumar K.V
2008-11-21 17:40 ` Eric Sandeen
2008-11-21 17:39 ` Eric Sandeen
2008-11-23 19:02 ` Theodore Tso
2008-11-24 6:40 ` Aneesh Kumar K.V
2008-11-23 14:00 ` Theodore Tso
2008-11-24 7:14 ` Alex Zhuravlev
2008-11-24 11:33 ` Aneesh Kumar K.V
2008-11-24 16:36 ` Alex Zhuravlev
2008-11-24 16:43 ` Aneesh Kumar K.V
2008-11-24 18:03 ` Alex Zhuravlev
2008-11-24 18:12 ` Aneesh Kumar K.V
2008-11-24 18:17 ` Alex Zhuravlev
2008-11-24 18:21 ` Aneesh Kumar K.V
2008-11-24 18:28 ` Alex Zhuravlev
2008-11-24 18:41 ` Alex Zhuravlev
2008-11-25 14:29 ` Frédéric Bohé
2008-11-25 16:38 ` Alex Zhuravlev
2008-11-23 13:37 ` [PATCH -V2 2/5] ext4: unlock group before ext4_error Theodore Tso
2008-11-23 13:43 ` Theodore Tso
2008-11-23 13:59 ` Aneesh Kumar K.V
2008-11-21 17:20 ` [PATCH -V2 1/5] ext4: Remove unneeded code Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124012113.GA2163@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=coyli@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.