From: Ingo Molnar <mingo@elte.hu>
To: "Török Edwin" <edwintorok@gmail.com>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] __used is needed for function referenced only from inline asm
Date: Mon, 24 Nov 2008 10:04:03 +0100 [thread overview]
Message-ID: <20081124090403.GA25218@elte.hu> (raw)
In-Reply-To: <1227514662-10848-1-git-send-email-edwintorok@gmail.com>
* Török Edwin <edwintorok@gmail.com> wrote:
> According to the gcc manual, the 'used' attribute should be applied to
> functions referenced only from inline assembly.
> This fixes a build failure with llvm-gcc-4.2, which deleted
> __mutex_lock_slowpath, __mutex_unlock_slowpath.
>
> Signed-off-by: Török Edwin <edwintorok@gmail.com>
> ---
> kernel/mutex.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
quite sad - it's gcc inline assembly after all - applied to
tip/core/locking (for v2.6.29). Should this get into v2.6.28 too?
Ingo
next prev parent reply other threads:[~2008-11-24 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 8:17 [PATCH] __used is needed for function referenced only from inline asm Török Edwin
2008-11-24 8:57 ` Geert Uytterhoeven
2008-11-24 9:22 ` Andi Kleen
2008-11-24 9:32 ` Andreas Schwab
2008-11-24 9:53 ` Andi Kleen
2008-11-24 9:04 ` Ingo Molnar [this message]
2008-11-24 9:50 ` Török Edwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081124090403.GA25218@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@linux.intel.com \
--cc=dhowells@redhat.com \
--cc=edwintorok@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.