From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L4dmx-0003CD-M6
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 10:55:52 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L4dmv-0003Ad-1L
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 10:55:50 -0500
Received: from [199.232.76.173] (port=46058 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L4dmt-00037y-Sd
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 10:55:48 -0500
Received: from outbound-va3.frontbridge.com ([216.32.180.16]:42599
	helo=VA3EHSOBE004.bigfish.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.60) (envelope-from <Christoph.Egger@amd.com>)
	id 1L4Xqg-0005Me-CF
	for qemu-devel@nongnu.org; Mon, 24 Nov 2008 04:35:18 -0500
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [Qemu-devel] [5778] Use MAP_ANON also for FreeBSD (Juergen Lock)
Date: Mon, 24 Nov 2008 11:35:06 +0200
References: <E1L3zJl-00044H-T7@cvs.savannah.gnu.org>
In-Reply-To: <E1L3zJl-00044H-T7@cvs.savannah.gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-ID: <200811241035.06359.Christoph.Egger@amd.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

On Saturday 22 November 2008 21:43:01 Blue Swirl wrote:
> Revision: 5778
>           http://svn.sv.gnu.org/viewvc/?view=3Drev&root=3Dqemu&revision=
=3D5778
> Author:   blueswir1
> Date:     2008-11-22 20:43:01 +0000 (Sat, 22 Nov 2008)
>
> Log Message:
> -----------
> Use MAP_ANON also for FreeBSD (Juergen Lock)

This is for *BSD in general.

> @@ -87,7 +89,8 @@
>      static int phys_ram_size =3D 0;
>      void *ptr;
>
> -#ifdef __OpenBSD__ /* no need (?) for a dummy file on OpenBSD */
> +/* no need (?) for a dummy file on OpenBSD/FreeBSD */
> +#if defined(__OpenBSD__) || defined(__FreeBSD__)

This should be:

#ifdef _BSD

>      int map_anon =3D MAP_ANON;
>  #else
>      int map_anon =3D 0;
> @@ -154,7 +157,7 @@
>      }
>      size =3D (size + 4095) & ~4095;
>      ftruncate(phys_ram_fd, phys_ram_size + size);
> -#endif /* !__OpenBSD__ */
> +#endif /* !(__OpenBSD__ || __FreeBSD__) */

This should be

#endif /* !_BSD */

>      ptr =3D mmap(NULL,
>                 size,
>                 PROT_WRITE | PROT_READ, map_anon | MAP_SHARED,



=2D-=20
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Gesch=C3=A4ftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplement=C3=A4r:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Gesch=C3=A4ftsf=C3=BChrer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy