From: Chr <chunkeey@web.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: John W Linville <linville@tuxdriver.com>
Subject: [PATCH] p54: fix wmm queue settings
Date: Mon, 24 Nov 2008 13:34:38 +0100 [thread overview]
Message-ID: <200811241334.38299.chunkeey@web.de> (raw)
This patch fixes a regression (introduced by 453fae72b2f19
"p54: more definitions form lmac_longbow.h and pda.h" )
It turned out that the "ret" variable wasn't initialized and
this caused the following warnings/errors to appear:
wmaster1: failed to set TX queue parameters for queue 2
wmaster1: failed to set TX queue parameters for queue 3
wmaster1: failed to set TX queue parameters for queue 1
wmaster1: failed to set TX queue parameters for queue 0
Signed-off-by: Christian Lamparter <chunkeey@web.de>
---
diff -Nurp a/drivers/net/wireless/p54/p54common.c b/drivers/net/wireless/p54/p54common.c
--- a/drivers/net/wireless/p54/p54common.c 2008-11-24 00:01:27.899490373 +0100
+++ b/drivers/net/wireless/p54/p54common.c 2008-11-24 13:07:09.053832187 +0100
@@ -1729,10 +1729,9 @@ static int p54_conf_tx(struct ieee80211_
if ((params) && !(queue > 4)) {
P54_SET_QUEUE(priv->qos_params[queue], params->aifs,
params->cw_min, params->cw_max, params->txop);
+ ret = p54_set_edcf(dev);
} else
ret = -EINVAL;
- if (!ret)
- ret = p54_set_edcf(dev);
mutex_unlock(&priv->conf_mutex);
return ret;
}
next reply other threads:[~2008-11-24 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 12:34 Chr [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-24 13:52 [PATCH] p54: fix wmm queue settings Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811241334.38299.chunkeey@web.de \
--to=chunkeey@web.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.