From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH 3/4] Support for device capability
Date: Mon, 24 Nov 2008 15:24:15 +0800
Message-ID: <200811241524.15530.sheng@linux.intel.com>
References: <1227258267-22901-1-git-send-email-sheng@linux.intel.com> <1227258267-22901-4-git-send-email-sheng@linux.intel.com> <49294C65.7070404@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: Anthony Liguori <anthony@codemonkey.ws>, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga06.intel.com ([134.134.136.21]:54550 "EHLO
	orsmga101.jf.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750751AbYKXH2G (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 24 Nov 2008 02:28:06 -0500
In-Reply-To: <49294C65.7070404@redhat.com>
Content-Disposition: inline
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sunday 23 November 2008 20:28:21 Avi Kivity wrote:
> Sheng Yang wrote:
> > This framework can be easily extended to support device capability, like
> > MSI/MSI-x.
>
> At least some of this should go into pci.c, so non-assigned devices can
> benefit.

So you means a capability configuration space for native QEmu? Yeah, that's 
reasonable if we can emulate them. :)
>
> >  static void assigned_dev_pci_write_config(PCIDevice *d, uint32_t
> > address, uint32_t val, int len) {
> >      int fd;
> >      ssize_t ret;
> > +    AssignedDevice *pci_dev = (AssignedDevice *)d;
>
> container_of()

Oops, I just think QEmu don't have this macro...

-- 
regards
Yang, Sheng