All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Coly Li <coyli@suse.de>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix similar typos to successfull
Date: Mon, 24 Nov 2008 17:16:23 +0000	[thread overview]
Message-ID: <20081124171623.GA25325@hack.voiplan.pt> (raw)
In-Reply-To: <492AE09A.7070204@suse.de>

On Tue, Nov 25, 2008 at 01:12:58AM +0800, Coly Li wrote:
>
>
>Randy Dunlap Wrote:
>> Coly Li wrote:
>>> When I review ocfs2 code, find there are 2 typos to "successfull". After doing grep "successfull "
>>> in kernel tree, 22 typos found totally --  great minds always think alike :)
>>>
>>> This patch fixes all the similar typos.
>>>
>>> Singed-off-by: Coly Li <coyli@suse.de>
>>> ---
>>>  Documentation/hwmon/abituguru-datasheet   |    4 ++--
>>>  Documentation/scsi/scsi_fc_transport.txt  |    4 ++--
>>>  arch/powerpc/platforms/cell/spufs/spufs.h |    2 +-
>>>  drivers/infiniband/hw/nes/nes_cm.c        |    2 +-
>>>  drivers/isdn/hardware/eicon/debuglib.h    |    2 +-
>>>  drivers/isdn/hardware/eicon/os_4bri.c     |    2 +-
>>>  drivers/isdn/hardware/eicon/os_bri.c      |    2 +-
>>>  drivers/isdn/hardware/eicon/os_pri.c      |    2 +-
>>>  drivers/mtd/ubi/kapi.c                    |    2 +-
>>>  drivers/net/wireless/ath5k/dma.c          |    2 +-
>>>  drivers/net/wireless/zd1211rw/zd_mac.c    |    2 +-
>>>  drivers/s390/block/dasd_3990_erp.c        |    2 +-
>>>  drivers/s390/block/dasd_int.h             |    2 +-
>>>  drivers/s390/char/tape_3590.c             |    2 +-
>>>  drivers/s390/cio/cio.c                    |    2 +-
>>>  drivers/s390/cio/qdio_main.c              |    2 +-
>>>  fs/ext4/extents.c                         |    2 +-
>>>  fs/ocfs2/dlmglue.c                        |    4 ++--
>>>  net/sctp/auth.c                           |    2 +-
>>>  19 files changed, 22 insertions(+), 22 deletions(-)
>> 
>> Ack all <deleted> patches.  However, I don't think that the
>> one below needs to use -ly.  Just change to "successful" IMO,
>> as in:  Log this successful return from ocfs2_dlm_lock
>> 
>So "return" here is noun, not verb ?


Here, yes. Becuase if it's a verb, it will be "returns successfully
from ... ". See the order? :)


-- 
"Sometimes the only way to stay sane is to go a little crazy."


      parent reply	other threads:[~2008-11-24 17:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 12:33 [PATCH] fix similar typos to successfull Coly Li
2008-11-24 16:25 ` Randy Dunlap
2008-11-24 17:12   ` Coly Li
2008-11-24 17:09     ` Randy Dunlap
2008-11-24 17:38       ` Coly Li
2008-11-24 17:16     ` Américo Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081124171623.GA25325@hack.voiplan.pt \
    --to=xiyou.wangcong@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=coyli@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.