From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] net: hp-plus uses eip_poll Date: Tue, 25 Nov 2008 21:49:20 -0800 (PST) Message-ID: <20081125.214920.86352252.davem@davemloft.net> References: <20081125195400.dbb46066.randy.dunlap@oracle.com> <20081125.210524.248687025.davem@davemloft.net> <492CE204.4090904@oracle.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk To: randy.dunlap@oracle.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57061 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750981AbYKZFtV (ORCPT ); Wed, 26 Nov 2008 00:49:21 -0500 In-Reply-To: <492CE204.4090904@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Randy Dunlap Date: Tue, 25 Nov 2008 21:43:32 -0800 > David Miller wrote: > > From: Randy Dunlap > > Date: Tue, 25 Nov 2008 19:54:00 -0800 > > > >> From: Randy Dunlap > >> > >> hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll(). > >> > >> drivers/built-in.o: In function `hpp_probe1': > >> hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll' > >> > >> Signed-off-by: Randy Dunlap > > > > I'll apply this to net-2.6 > > > > But can you take a look at what I just pushed out to > > net-next-2.6 wrt. this driver and give me a hand untangling > > things there? > > > > Thanks a lot Randy! > > Looks to me like both of this week's hp-plus patches (one to > drivers/net/Makefile & one to drivers/net/hp-plus.c) are > still needed there (unless you applied those patches but > didn't push or the push isn't showing up yet). Ok. I will need to merge. But in net-next-2.6 that ->poll_controller is set in the hp-plus.c driver's netdev_ops structure. That's what I wanted you to look at.