From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Linux-I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [patch 2.6.28-rc5] i2c: remove i2c_adapter.clist_lock
Date: Tue, 25 Nov 2008 03:27:08 -0800 [thread overview]
Message-ID: <200811250327.08464.david-b@pacbell.net> (raw)
In-Reply-To: <20081125120100.6581f394-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
On Tuesday 25 November 2008, Jean Delvare wrote:
>
> > I did test this with the legacy "eeprom" and "i2c-stub" as you had
> > suggested. Worked fine ... this is different from previous passes,
> > as it removes the lock instead of the list, and doesn't attempt to
> > change how the list is (mis/ab)used.
>
> Which kernel version? Since 2.6.27, the eeprom driver is no longer a
> legacy driver. Instead it's a new-style driver with the
> optional .detect() callback.
2.6.28-rc6 ... hmm, seeing the top of that driver with
/* Addresses to scan */
static const unsigned short normal_i2c[] = { 0x50, 0x51, 0x52, 0x53, 0x54,
0x55, 0x56, 0x57, I2C_CLIENT_END };
/* Insmod parameters */
I2C_CLIENT_INSMOD_1(eeprom);
strongly implied that it's still a legacy driver. But
at the bottom, I see otherwise. I suppose your "how to
test such stuff" message predated 2.6.27 ... :)
next prev parent reply other threads:[~2008-11-25 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-20 22:38 [patch 2.6.28-rc5] i2c: remove i2c_adapter.clist_lock David Brownell
[not found] ` <200811201438.08788.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-11-25 9:12 ` Jean Delvare
[not found] ` <20081125101203.58e3f032-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-11-25 10:24 ` David Brownell
[not found] ` <200811250224.01610.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-11-25 11:01 ` Jean Delvare
[not found] ` <20081125120100.6581f394-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-11-25 11:27 ` David Brownell [this message]
[not found] ` <200811250327.08464.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-11-25 11:54 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811250327.08464.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.