All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Patrick McHardy <kaber@trash.net>
Cc: Shane Goulden <shane@matrixau.net>, netfilter-devel@vger.kernel.org
Subject: Re: ip_conntrack_ftp messages
Date: Tue, 25 Nov 2008 03:44:46 +1030	[thread overview]
Message-ID: <200811250344.46392.rusty@rustcorp.com.au> (raw)
In-Reply-To: <492A9DD9.1090307@trash.net>

On Monday 24 November 2008 22:58:09 Patrick McHardy wrote:
> Rusty Russell wrote:
> > 		if (net_ratelimit())
> > 			printk("conntrack_ftp: partial %s %u+%u\n",
> > 			       search[dir][i].pattern,
> > 			       ntohl(th->seq), datalen);
>
> Its strange that FTP is apparently working since we drop those packets.
> I'm not sure about downgrading that message, its there to inform the
> user of an exceptional action (dropping of packets within conntrack).

Actually, we drop the packets *so* it will work.  The idea is that they'll 
coalesce and send the whole packet next time.

If not, well, they don't get any more packes through, but without connection 
tracking the other connections wouldn't work anyway (if the conntrack is being 
used for NAT or filtering).

IIRC wu-ftpd used to trigger this (multiple write syscalls for the ip address 
and nagle sometimes hit in the middle; go figure).

Cheers,
Rusty.

  parent reply	other threads:[~2008-11-24 17:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <31563483.01227485595724.JavaMail.shane@shane-laptop>
2008-11-24  4:15 ` ip_conntrack_ftp messages Rusty Russell
2008-11-24 12:28   ` Patrick McHardy
2008-11-24 15:24     ` Phil Oester
2008-11-24 15:32       ` Patrick McHardy
2008-11-24 15:54         ` Jan Engelhardt
2008-11-24 16:08           ` Patrick McHardy
2008-11-24 16:23           ` Pascal Hambourg
2008-11-24 17:14     ` Rusty Russell [this message]
2008-11-24 17:34       ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811250344.46392.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shane@matrixau.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.