From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org
Subject: Re: [PATCH] use limited register constraint for setnz
Date: Tue, 25 Nov 2008 08:22:09 +0100 [thread overview]
Message-ID: <20081125072209.GC9660@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0811250040060.2977@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Impact: fix in compiling
>
> GCC can decide to use %dil when "r" is used, which is not valid for
> setnz.
>
> This bug was brought out by Stephen Rothwell's merging of the
> branch tracer into linux-next.
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
>
> diff --git a/arch/x86/boot/tty.c b/arch/x86/boot/tty.c
> index 0be77b3..c2121d2 100644
> --- a/arch/x86/boot/tty.c
> +++ b/arch/x86/boot/tty.c
> @@ -74,7 +74,7 @@ static int kbd_pending(void)
> {
> u8 pending;
> asm volatile("int $0x16; setnz %0"
> - : "=rm" (pending)
> + : "=Qm" (pending)
> : "a" (0x0100));
> return pending;
> }
applied to tip/x86/urgent, thanks Steve!
Ingo
prev parent reply other threads:[~2008-11-25 7:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 5:42 [PATCH] use limited register constraint for setnz Steven Rostedt
2008-11-25 7:22 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125072209.GC9660@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.