From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Webb <chris@arachsys.com>
Subject: Re: [Qemu-devel] [PATCH] Fix off-by-one bug limiting VNC passwords
	to 7 chars
Date: Tue, 25 Nov 2008 10:09:35 +0000
Message-ID: <20081125100935.GI2380@arachsys.com>
References: <20081123113147.GA12832@arachsys.com> <20081123123101.GC17042@networkno.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
To: Thiemo Seufer <ths@networkno.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from alpha.arachsys.com ([91.203.57.7]:38037 "EHLO
	alpha.arachsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751860AbYKYKJl (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 25 Nov 2008 05:09:41 -0500
Content-Disposition: inline
In-Reply-To: <20081123123101.GC17042@networkno.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Thiemo Seufer <ths@networkno.de> writes:

> Chris Webb wrote:
[...]
> > -	monitor_readline("Password: ", 1, password, sizeof(password)-1);
> > +	monitor_readline("Password: ", 1, password, sizeof(password));
> >  	password[sizeof(password)-1] = '\0';
> 
> The next line can go as well, the string is already NULL terminated.

You're quite right. I'll update the two patches to reflect this change.

Cheers,

Chris.