All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eliot Blennerhassett <linux@audioscience.com>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>,
	"Keith A. Milner" <maillist@superlative.org>
Subject: Build patch failure.
Date: Tue, 25 Nov 2008 13:45:53 +1300	[thread overview]
Message-ID: <200811251345.53742.linux@audioscience.com> (raw)
In-Reply-To: <200811242356.52786.maillist@superlative.org>

On Tuesday 25 November 2008 12:56:52 Keith A. Milner wrote:
> On Monday 24 November 2008 23:47:27 Eliot Blennerhassett wrote:
> > I see this too. My kernel: ubuntu 2.6.24-21-generic
>
> I'm on Mandriva kernel version 2.6.24.7
>
> > No. git is right.
>
> Thank you very much for confirming this. I thought I was missing something,
> but I couldn't see what.
>
> I believe the kernerl version shouldn't matter as this error occurs when
> trying to apply a patch to one of the main files. I guess we have to sit
> tight for someone to fix this, or just delete and ignore the patch file for
> now?

I applied the rejected part of the patch manually.
(cp init.c.orig init.c; patch init.c init.patch;  edit init.c and apply 
init.c.rej manually)

But now have another reject in hda_beep.c (if you aren't building for 
intel-hda this might not affect you).
Well I fixed this manually and now all OK.

Heres the .rej for hda_beep.c

***************
*** 87,93 ****
  		return -ENOMEM;
  	snprintf(beep->phys, sizeof(beep->phys),
  		"card%d/codec#%d/beep0", codec->bus->card->number, codec->addr);
  	input_dev = input_allocate_device();
  
  	/* setup digital beep device */
  	input_dev->name = "HDA Digital PCBeep";
--- 93,103 ----
  		return -ENOMEM;
  	snprintf(beep->phys, sizeof(beep->phys),
  		"card%d/codec#%d/beep0", codec->bus->card->number, codec->addr);
+ #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 15)
  	input_dev = input_allocate_device();
+ #else
+ 	input_dev = kzalloc(sizeof(*input_dev), GFP_KERNEL);
+ #endif
  
  	/* setup digital beep device */
  	input_dev->name = "HDA Digital PCBeep";


cheers


-- 
--
Eliot Blennerhassett
www.audioscience.com

  reply	other threads:[~2008-11-25  0:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 23:10 CVS, git, or something else? Keith A. Milner
2008-11-24 23:47 ` CVS, git, or something else? Build patch failure Eliot Blennerhassett
2008-11-24 23:56   ` Keith A. Milner
2008-11-25  0:45     ` Eliot Blennerhassett [this message]
2008-11-25  0:49       ` Takashi Iwai
2008-11-25  1:00         ` Eliot Blennerhassett
2008-11-25  1:18           ` Takashi Iwai
2008-11-25 20:41             ` Eliot Blennerhassett
2008-11-25 23:53               ` Keith A. Milner
2008-11-26  0:44                 ` Keith A. Milner
2008-11-26  6:27               ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811251345.53742.linux@audioscience.com \
    --to=linux@audioscience.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=maillist@superlative.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.