From: Ingo Molnar <mingo@elte.hu>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org, tglx@linutronix.de,
markus.t.metzger@gmail.com, roland@redhat.com,
akpm@linux-foundation.org, mtk.manpages@gmail.com,
eranian@googlemail.com, juan.villacis@intel.com
Subject: Re: [patch 5/9] x86, bts: base in-kernel ds interface on handles
Date: Tue, 25 Nov 2008 17:36:24 +0100 [thread overview]
Message-ID: <20081125163624.GD22504@elte.hu> (raw)
In-Reply-To: <20081125090125.A31137@sedona.ch.intel.com>
* Markus Metzger <markus.t.metzger@intel.com> wrote:
> +static void ds_release(struct ds_tracer *tracer, enum ds_qualifier qual)
> +{
> + if (tracer->context) {
> + BUG_ON(tracer->context->owner[qual] != tracer);
please use WARN_ON_ONCE() instead of crashing the box. (this is true
in a number of other places as well in ds.c)
Ingo
prev parent reply other threads:[~2008-11-25 16:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 8:01 [patch 5/9] x86, bts: base in-kernel ds interface on handles Markus Metzger
2008-11-25 16:36 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125163624.GD22504@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=eranian@googlemail.com \
--cc=hpa@zytor.com \
--cc=juan.villacis@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=mtk.manpages@gmail.com \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.