All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@sun.com>
To: Solofo.Ramangalahy@bull.net
Cc: Theodore Tso <tytso@MIT.EDU>, linux-ext4@vger.kernel.org
Subject: Re: [RFC 0/2] ext4: zero uninitialized inode tables
Date: Tue, 25 Nov 2008 14:10:43 -0700	[thread overview]
Message-ID: <20081125211043.GT3186@webber.adilger.int> (raw)
In-Reply-To: <18731.61311.620237.554814@frecb006361.adech.frec.bull.fr>

On Nov 25, 2008  13:28 +0100, Solofo.Ramangalahy@bull.net wrote:
> Appart from the data structures change you mentionned, these changes
> were discussed:
> . a mount option to disable the threads when doing testing/performance
>   benchmarking

Sure.

> . a flag in s_flags field of struct ext4_super_block to indicate that
>   the zeroing has been done on all the groups. Possibly reset with
>   resize.

I was thinking that it makes sense to have this same thread do checking
of all the block group metadata as it traverses the filesystem.  That
includes validating the GDT checksums, checking the existing block and
inode bitmaps (and possibly checksums for them, when that is implemented),
along with zeroing the inode table.

The only requirement is that there only be a single such thread running
on the filesystem at one time, and that if the filesystem is unmounted
that the thread be killed before the unmount is completed.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.


      parent reply	other threads:[~2008-11-25 21:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-21 10:23 [RFC 0/2] ext4: zero uninitialized inode tables Solofo.Ramangalahy
2008-11-21 10:23 ` [RFC 1/2] ext4 resize: Mark the added group with EXT4_BG_INODE_ZEROED flag Solofo.Ramangalahy
2008-11-24 23:25   ` Andreas Dilger
2008-11-25 11:27     ` Solofo.Ramangalahy
2008-11-25 21:18       ` Andreas Dilger
2008-11-27  4:50   ` Theodore Tso
2008-11-27  9:30     ` Solofo.Ramangalahy
2008-11-27 22:35       ` Theodore Tso
2008-11-27 23:09         ` Andreas Dilger
2008-11-21 10:23 ` [RFC 2/2] ext4: module to initialize the inode table when using mkfs option lazy_itable_init Solofo.Ramangalahy
2008-11-25  5:32 ` [RFC 0/2] ext4: zero uninitialized inode tables Theodore Tso
2008-11-25  8:35   ` Andreas Dilger
2008-11-25 12:28   ` Solofo.Ramangalahy
2008-11-25 18:52     ` Theodore Tso
2008-11-25 21:10     ` Andreas Dilger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081125211043.GT3186@webber.adilger.int \
    --to=adilger@sun.com \
    --cc=Solofo.Ramangalahy@bull.net \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@MIT.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.