From: Greg KH <greg@kroah.com>
To: "Darrick J. Wong" <djwong@us.ibm.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fakephp: Allocate PCI resources before adding the device
Date: Tue, 25 Nov 2008 13:43:24 -0800 [thread overview]
Message-ID: <20081125214324.GA23177@kroah.com> (raw)
In-Reply-To: <20081125212422.22631.69619.stgit@elm3a70.beaverton.ibm.com>
On Tue, Nov 25, 2008 at 01:24:22PM -0800, Darrick J. Wong wrote:
> For PCI devices, pci_bus_assign_resources() must be called to set up the
> pci_device->resource array before pci_bus_add_devices() can be called, else
> attempts to load drivers results in BAR collision errors where there are none.
> This is not done in fakephp, so devices can be "unplugged" but scanning the
> parent bus won't bring the devices back due to resource unallocation. Move the
> pci_bus_add_device-calling logic into pci_rescan_bus and preface it with a call
> to pci_bus_assign_resources so that we only have to (re)allocate resources once
> per bus where a new device is found.
>
> Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Darrick, I am no longer the PCI maintainer, Jesse is.
Please resend this to him, and the linux-pci mailing list if you want it
to have a chance to get accepted.
thanks,
greg k-h
next prev parent reply other threads:[~2008-11-25 21:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 21:24 [PATCH] fakephp: Allocate PCI resources before adding the device Darrick J. Wong
2008-11-25 21:43 ` Greg KH [this message]
2008-11-26 4:46 ` Trent Piepho
2008-11-26 7:48 ` Darrick J. Wong
2008-11-26 9:56 ` Trent Piepho
2008-11-26 18:18 ` Darrick J. Wong
2008-11-26 22:23 ` Trent Piepho
2008-11-26 22:55 ` Alex Chiang
2008-11-27 1:44 ` Trent Piepho
2008-11-27 2:42 ` Matthew Wilcox
2008-11-28 10:11 ` Trent Piepho
2008-11-28 18:57 ` Matthew Wilcox
2008-11-28 21:21 ` Trent Piepho
2008-11-28 21:30 ` Matthew Wilcox
2008-12-01 1:10 ` Problems with fakephp Trent Piepho
2008-12-16 20:28 ` fixup PCI device booleans in sysfs Jesse Barnes
2008-11-28 23:18 ` [PATCH] fakephp: Allocate PCI resources before adding the device Alex Chiang
2008-12-01 13:00 ` Problems with fakephp Trent Piepho
2008-12-02 3:16 ` Alex Chiang
2008-12-03 4:07 ` Trent Piepho
2008-12-03 4:38 ` Alex Chiang
2008-12-03 17:22 ` Rolf Eike Beer
2008-12-03 17:43 ` Alex Chiang
2008-12-03 17:55 ` Rolf Eike Beer
2008-12-03 18:22 ` Alex Chiang
2008-12-08 21:09 ` Rolf Eike Beer
2008-12-01 13:36 ` Trent Piepho
2008-12-01 14:08 ` [PATCH] PCI: Method for removing PCI devices Trent Piepho
2008-12-01 14:40 ` Greg KH
2008-12-01 14:08 ` [PATCH] PCI: Legacy fakephp driver Trent Piepho
2008-11-27 1:52 ` [PATCH] fakephp: Allocate PCI resources before adding the device Darrick J. Wong
2008-11-28 9:51 ` Trent Piepho
2008-11-28 18:42 ` Rolf Eike Beer
2008-11-28 21:06 ` Trent Piepho
2008-12-01 17:08 ` Rolf Eike Beer
2008-12-16 19:33 ` Jesse Barnes
2008-12-16 20:56 ` [PATCH] fakephp: Allocate PCI resources before adding the?device Darrick J. Wong
2008-12-21 2:23 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081125214324.GA23177@kroah.com \
--to=greg@kroah.com \
--cc=djwong@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.