From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1L55Hj-0003G7-1X for mharc-grub-devel@gnu.org; Tue, 25 Nov 2008 16:17:27 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L55Hh-0003Fs-7e for grub-devel@gnu.org; Tue, 25 Nov 2008 16:17:25 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L55Hf-0003FU-FI for grub-devel@gnu.org; Tue, 25 Nov 2008 16:17:24 -0500 Received: from [199.232.76.173] (port=37774 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L55Hf-0003FQ-8a for grub-devel@gnu.org; Tue, 25 Nov 2008 16:17:23 -0500 Received: from ns39764.ovh.net ([91.121.25.85]:43695 helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L55Hf-00026K-1R for grub-devel@gnu.org; Tue, 25 Nov 2008 16:17:23 -0500 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 39DAA3DA3B for ; Tue, 25 Nov 2008 22:17:20 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Tue, 25 Nov 2008 22:17:17 +0100 User-Agent: KMail/1.9.9 References: <20081122153509.GA576@thorin> In-Reply-To: <20081122153509.GA576@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811252217.18586.okuji@enbug.org> X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] (ata.mod) avoid passing grub_errno to upper layer X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 21:17:25 -0000 On Saturday 22 November 2008 16:35:09 Robert Millan wrote: > When an error is detected by ata.mod during drive scan, it will pass it to > the upper layer. This results in GRUB aborting when trying to enter normal > mode, even if the error is not critical (e.g. affects a drive not used > during boot). > > There are a number of places in ata.mod where these errors could be > handled, so I'm not sure if my proposed change would be the best approach. > Some comment would be appreciated. This is one way, but I think the upper layer should be more robust against errors raised from modules. For example, we can unload a module, and clear GRUB_ERRNO, if the init function in this module return an error. Regards, Okuji