All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	"John W. Linville" <linville@tuxdriver.com>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
	Steven Rostedt <srostedt@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: linux-next: ftrace tree build failure
Date: Tue, 25 Nov 2008 16:14:58 -0800	[thread overview]
Message-ID: <20081126001458.GM5950@tesla> (raw)
In-Reply-To: <20081126110847.4d9cf9f2.sfr@canb.auug.org.au>

On Tue, Nov 25, 2008 at 04:08:47PM -0800, Stephen Rothwell wrote:
> Hi,
> 
> On Tue, 25 Nov 2008 10:46:30 -0800 "Luis R. Rodriguez" <lrodriguez@atheros.com> wrote:
> >
> > On Tue, Nov 25, 2008 at 06:57:01AM -0800, John W. Linville wrote:
> > > I have the patch now...thanks!
> > > 
> > > Now, if I only knew why my build didn't fail with the original code...
> > 
> > Same here I run tests with sparse too prior to sending patches.
> 
> It is valid C.
> 
> 	if (a, b)
> 
> you evaluate a and discard it then evaluate b and that is the value of
> the conditional expression.  In this case b is just a string which is
> effectively a non NULL "const char *" which is just non zero as far as if
> is concerned. So the conditional expression evaluates to (constant)
> true.  So this was, in fact a bug ...

Thanks, and good catch :)

  Luis

  reply	other threads:[~2008-11-26  0:15 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25  3:07 linux-next: ftrace tree build failure Stephen Rothwell
2008-11-25  3:21 ` Steven Rostedt
2008-11-25  7:28 ` Ingo Molnar
2008-11-25  7:43   ` Stephen Rothwell
2008-11-25  8:04     ` Ingo Molnar
2008-11-25 14:57       ` John W. Linville
2008-11-25 18:46         ` Luis R. Rodriguez
2008-11-26  0:08           ` Stephen Rothwell
2008-11-26  0:14             ` Luis R. Rodriguez [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-01-07  0:53 Stephen Rothwell
2009-01-07  9:55 ` Ingo Molnar
2009-01-07 21:20   ` Stephen Rothwell
2009-01-02  9:07 Stephen Rothwell
2009-01-02  9:14 ` Ingo Molnar
2009-01-02 10:22   ` Stephen Rothwell
2009-01-02 11:16     ` Ingo Molnar
2008-11-25  3:21 Stephen Rothwell
2008-11-25  3:48 ` Steven Rostedt
2008-11-25  4:13   ` Stephen Rothwell
2008-11-25  4:31     ` Steven Rostedt
2008-11-25  5:09       ` Stephen Rothwell
2008-11-25  5:44         ` Steven Rostedt
2008-11-25  6:57           ` Stephen Rothwell
2008-11-25  7:14             ` Ingo Molnar
2008-11-25  7:26               ` Stephen Rothwell
2008-11-25  5:24     ` Steven Rostedt
2008-08-25  3:08 Stephen Rothwell
2008-08-25  6:05 ` Ingo Molnar
2008-08-25  6:11   ` Ingo Molnar
2008-08-25  6:31     ` Stephen Rothwell
2008-08-25  3:01 Stephen Rothwell
2008-08-25  6:09 ` Ingo Molnar
2008-08-25 16:42   ` Steven Rostedt
2008-08-25 16:46     ` Steven Rostedt
2008-08-15  2:27 Stephen Rothwell
2008-08-15  7:56 ` Ingo Molnar
2008-08-15  8:29   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126001458.GM5950@tesla \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@Atheros.com \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=linux-next@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mingo@elte.hu \
    --cc=sfr@canb.auug.org.au \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.