All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [patch 11/14] apne: convert to net_device_ops
Date: Tue, 25 Nov 2008 17:14:30 -0800	[thread overview]
Message-ID: <20081126011546.032495820@linux-foundation.org> (raw)
In-Reply-To: 20081126011419.402319779@linux-foundation.org

[-- Attachment #1: apne-netdev-ops.patch --]
[-- Type: text/plain, Size: 1815 bytes --]

Yet another driver.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>


--- a/drivers/net/apne.c	2008-11-25 14:33:02.000000000 -0800
+++ b/drivers/net/apne.c	2008-11-25 14:34:43.000000000 -0800
@@ -78,9 +78,6 @@
 struct net_device * __init apne_probe(int unit);
 static int apne_probe1(struct net_device *dev, int ioaddr);
 
-static int apne_open(struct net_device *dev);
-static int apne_close(struct net_device *dev);
-
 static void apne_reset_8390(struct net_device *dev);
 static void apne_get_8390_hdr(struct net_device *dev, struct e8390_pkt_hdr *hdr,
 			  int ring_page);
@@ -314,6 +311,7 @@ static int __init apne_probe1(struct net
 
     dev->base_addr = ioaddr;
     dev->irq = IRQ_AMIGA_PORTS;
+    dev->netdev_ops = &ei_netdev_ops;
 
     /* Install the Interrupt handler */
     i = request_irq(dev->irq, apne_interrupt, IRQF_SHARED, DRV_NAME, dev);
@@ -337,11 +335,7 @@ static int __init apne_probe1(struct net
     ei_status.block_input = &apne_block_input;
     ei_status.block_output = &apne_block_output;
     ei_status.get_8390_hdr = &apne_get_8390_hdr;
-    dev->open = &apne_open;
-    dev->stop = &apne_close;
-#ifdef CONFIG_NET_POLL_CONTROLLER
-    dev->poll_controller = ei_poll;
-#endif
+
     NS8390_init(dev, 0);
 
     pcmcia_ack_int(pcmcia_get_intreq());		/* ack PCMCIA int req */
@@ -352,22 +346,6 @@ static int __init apne_probe1(struct net
     return 0;
 }
 
-static int
-apne_open(struct net_device *dev)
-{
-    ei_open(dev);
-    return 0;
-}
-
-static int
-apne_close(struct net_device *dev)
-{
-    if (ei_debug > 1)
-	printk("%s: Shutting down ethercard.\n", dev->name);
-    ei_close(dev);
-    return 0;
-}
-
 /* Hard reset the card.  This used to pause for the same period that a
    8390 reset command required, but that shouldn't be necessary. */
 static void



  parent reply	other threads:[~2008-11-26  1:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26  1:14 [patch 00/14] Network devices ops (wave 4) Stephen Hemminger
2008-11-26  1:14 ` [patch 01/14] 8390: add common net_device ops Stephen Hemminger
2008-11-26  1:14 ` [patch 02/14] wd: use net_device_ops Stephen Hemminger
2008-11-26  1:14 ` [patch 03/14] hp-plus: convert to net_device_ops Stephen Hemminger
2008-11-26  1:14 ` [patch 04/14] smc: " Stephen Hemminger
2008-11-26  1:14 ` [patch 05/14] ne3210: " Stephen Hemminger
2008-11-26  1:14 ` [patch 06/14] es3210: " Stephen Hemminger
2008-11-26  1:14 ` [patch 07/14] e2100: " Stephen Hemminger
2008-11-26  1:14 ` [patch 08/14] lne390: " Stephen Hemminger
2008-11-26  1:14 ` [patch 09/14] hp: " Stephen Hemminger
2008-11-26  1:14 ` [patch 10/14] ne2: " Stephen Hemminger
2008-11-26  1:14 ` Stephen Hemminger [this message]
2008-11-26  1:14 ` [patch 12/14] stnic: " Stephen Hemminger
2008-11-26  1:14 ` [patch 13/14] 3c503: " Stephen Hemminger
2008-11-26  1:14 ` [patch 14/14] ne2000: " Stephen Hemminger
2008-11-26  5:06 ` [patch 00/14] Network devices ops (wave 4) David Miller
2008-11-26  9:53   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126011546.032495820@linux-foundation.org \
    --to=shemminger@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.