From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753614AbYKZCmx (ORCPT ); Tue, 25 Nov 2008 21:42:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752322AbYKZCmo (ORCPT ); Tue, 25 Nov 2008 21:42:44 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:37076 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbYKZCmo (ORCPT ); Tue, 25 Nov 2008 21:42:44 -0500 Date: Wed, 26 Nov 2008 03:42:32 +0100 From: Ingo Molnar To: Steven Rostedt Cc: Frederic Weisbecker , Linux Kernel Subject: Re: [PATCH] tracing/function-return-tracer: set a more human readable output Message-ID: <20081126024232.GA31342@elte.hu> References: <492C90E5.8070907@gmail.com> <20081126003936.GA26937@elte.hu> <20081126021450.GA17617@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > > On Wed, 26 Nov 2008, Ingo Molnar wrote: > > > > > the regex filter doesnt work well yet when used with the graph tracer: > > > > [ 2994.079079] ------------[ cut here ]------------ > > [ 2994.079079] WARNING: at kernel/trace/ftrace.c:373 ftrace_bug+0x8c/0x1ce() > > [ 2994.079079] Modules linked in: > > [ 2994.079079] Pid: 12, comm: kstop/0 Not tainted 2.6.28-rc6-tip #2056 > > [ 2994.079079] Call Trace: > > [ 2994.079079] [] warn_on_slowpath+0x46/0x60 > > [ 2994.079079] [] ? trace_graph_return+0x89/0xa7 > > [ 2994.079079] [] ? trace_graph_return+0x89/0xa7 > > [ 2994.079079] [] ? ftrace_return_to_handler+0x6b/0x74 > > [ 2994.079079] [] ? memcpy+0xe/0x31 > > [ 2994.079079] [] ? rb_commit+0x29/0x2d > > [ 2994.079079] [] ? ring_buffer_unlock_commit+0x15/0x1a > > [ 2994.079079] [] ? ftrace_modify_code+0x21/0xa3 > > [ 2994.079079] [] ? ftrace_return_to_handler+0x6b/0x74 > > [ 2994.079079] [] ? probe_kernel_read+0xe/0x5c > > [ 2994.079079] [] ? trace_selftest_dynamic_test_func+0x3/0xc > > [ 2994.079079] [] ? return_to_handler+0xa/0x14 > > [ 2994.079079] [] ? trace_selftest_dynamic_test_func+0x3/0xc > > [ 2994.079079] [] ? ftrace_modify_code+0x38/0xa3 > > [ 2994.079079] [] ? trace_selftest_dynamic_test_func+0x3/0xc > > [ 2994.079079] [] ftrace_bug+0x8c/0x1ce > > [ 2994.079079] [] ftrace_replace_code+0x111/0x13d > > [ 2994.079079] [] ? stop_cpu+0x0/0xa5 > > [ 2994.079079] [] __ftrace_modify_code+0x1e/0x32 > > [ 2994.079079] [] stop_cpu+0x6b/0xa5 > > [ 2994.079079] [] return_to_handler+0x0/0x14 > > [ 2994.079079] [] return_to_handler+0x0/0x14 > > [ 2994.079079] [] ? autoremove_wake_function+0x0/0x35 > > [ 2994.079079] [] ? worker_thread+0x0/0xc7 > > [ 2994.079079] [] kthread+0x40/0x66 > > [ 2994.079079] [] ? kthread+0x0/0x66 > > [ 2994.079079] [] kernel_thread_helper+0x7/0x10 > > [ 2994.079079] ---[ end trace bff97d149b80ecde ]--- > > [ 2994.079079] ftrace failed to modify [] trace_selftest_dynamic_test_func+0x3/0xc > > [ 2994.079079] actual: e8:0c:1a:fa:ff > > > > produced via: > > > > # cd /debug/tracing/ > > # cat set_ftrace_filter > > # echo schedule > set_ftrace_filter > > # cat set_ftrace_filter > > cat: set_ftrace_filter: No such device > > This is probably fixed with my patch set. yeah - but note that the graph-tracer rename came in the way of them. Mind redoing your two patches ontop of latest tip/master? Ingo