All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Huang Ying <ying.huang@intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
	Bernhard Walle <bwalle@suse.de>,
	"kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: Re: [PATCH] Fix kexec x86_64 load failed bug
Date: Wed, 26 Nov 2008 16:48:31 +0900	[thread overview]
Message-ID: <20081126074829.GD30657@verge.net.au> (raw)
In-Reply-To: <1227682058.2442.19.camel@yhuang-dev.sh.intel.com>

On Wed, Nov 26, 2008 at 02:47:38PM +0800, Huang Ying wrote:
> On Wed, 2008-11-26 at 14:16 +0800, Simon Horman wrote:
> > On Wed, Nov 26, 2008 at 12:25:51PM +0800, Huang Ying wrote:
> > > On Wed, 2008-11-26 at 11:25 +0800, Randy Dunlap wrote:
> > > > This isn't kernel code?  Where is /purgatory/ ?
> > > > 
> > > > Anyway, for kernel code, that should be:
> > > > char *cmdline_end = NULL;
> > > 
> > > This patch is against kexec tools, not kernel.
> > > 
> > > Best Regards,
> > > Huang Ying
> > 
> > Hi Huang,
> > 
> > I think that I would prefer "char *cmdline_end = NULL;" for kexec-tools
> > code too.
> 
> Patch v2 follows with NULL instead of 0.

Thanks, applied.

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2008-11-26  7:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-25 12:47 kexec does not load Bernhard Walle
2008-11-26  1:20 ` [PATCH] Fix kexec x86_64 load failed bug Huang Ying
2008-11-26  3:25   ` Randy Dunlap
2008-11-26  4:25     ` Huang Ying
2008-11-26  6:16       ` Simon Horman
2008-11-26  6:47         ` Huang Ying
2008-11-26  7:48           ` Simon Horman [this message]
2008-11-26  9:07             ` Bernhard Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126074829.GD30657@verge.net.au \
    --to=horms@verge.net.au \
    --cc=bwalle@suse.de \
    --cc=kexec@lists.infradead.org \
    --cc=randy.dunlap@oracle.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.