All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: eranian@gmail.com
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	mingo@elte.hu, x86@kernel.org, andi@firstfloor.org,
	sfr@canb.auug.org.au
Subject: Re: [patch 21/24] perfmon: Intel architectural PMU support (x86)
Date: Wed, 26 Nov 2008 17:45:11 +0100	[thread overview]
Message-ID: <20081126164511.GA6703@one.firstfloor.org> (raw)
In-Reply-To: <7c86c4470811260745s293ae0bbw1cf53642d4f88416@mail.gmail.com>

> Both perfmon_intel_arch.c and perfmon_amd64.c are supposed to be kernel modules.
> They are hardcoded right now to make the patch simpler. Have PMU description be
> modules is a key features because it allows adding new processor support without
> necessarily patch the core kernel or rebooting. This has been working

To install the new processor in the first place you have 
to reboot anyways.

Also typically at least for new families (which tend to be the
only ones with radically new performance counters) it's typically
needed to change some things in the core kernel anyways. So 
this doesn't seem like a really useful feature.

> nicely on Itanium.
> With the introduction of Intel architectural Perfmon (IA32 SDM chapter
> 18), this becomes
> possible on Intel X86 as well.

It becomes possible, but without having to use any modules. It should
just work.

Probably even without it worked -- at least if you limit yourself to 
family 6 -- because the register layout all stayed the same too.

That said having modular PMUs is probably a good thing for
distribution kernels, but there is really no need for any 
code compromises just to avoid a core kernel patch now and then.

-Andi

  parent reply	other threads:[~2008-11-26 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-26  8:42 [patch 21/24] perfmon: Intel architectural PMU support (x86) eranian
2008-11-26 14:55 ` Thomas Gleixner
2008-11-26 15:45   ` stephane eranian
2008-11-26 16:10     ` Thomas Gleixner
2008-11-26 16:45     ` Andi Kleen [this message]
2008-12-02  3:09   ` stephane eranian
  -- strict thread matches above, loose matches on Subject: below --
2008-11-25 21:36 eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081126164511.GA6703@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=eranian@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.