All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chia-I Wu <olvaffe@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: video4linux-list@redhat.com, noodles@earth.li,
	qce-ga-devel@lists.sourceforge.net
Subject: Re: Please test the gspca-stv06xx branch
Date: Thu, 27 Nov 2008 18:59:32 +0800	[thread overview]
Message-ID: <20081127105931.GD19421@m500.domain> (raw)
In-Reply-To: <492E7906.905@redhat.com>

On Thu, Nov 27, 2008 at 11:40:06AM +0100, Hans de Goede wrote:
> Chia-I Wu, I'm afraid this might conflict with your HDCS work, as it is 
> against Erik's latest hg tree, so without your patches. I noticed you 
> were defining your own read/write register functions which really seems 
> the wrong thing todo, hopefully with my new functions you can use those 
> directly, or ?
IMO, it is almost always a good thing that each driver defines its own
wrapping reg read/write functions.  It is less confusing and saves
typings.  It makes the sub-driver loosely coupled with the main driver.
And, the compiler will do the right thing, and optimize them out if
appropriate.

-- 
Regards,
olv

--
video4linux-list mailing list
Unsubscribe mailto:video4linux-list-request@redhat.com?subject=unsubscribe
https://www.redhat.com/mailman/listinfo/video4linux-list

  parent reply	other threads:[~2008-11-27 10:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-24 21:00 Please test the gspca-stv06xx branch Erik Andrén
2008-11-25  8:20 ` Chia-I Wu
2008-11-25 11:22   ` Erik Andrén
2008-11-25 11:39     ` Chia-I Wu
2008-11-25 12:02       ` Erik Andrén
     [not found]   ` <492E7906.905@redhat.com>
2008-11-27 10:59     ` Chia-I Wu [this message]
2008-11-27 11:55       ` Erik Andrén
2008-11-27 16:00         ` Chia-I Wu
     [not found]           ` <492EE597.7010100@redhat.com>
2008-11-28  4:26             ` Chia-I Wu
2008-11-27 11:51     ` Erik Andrén
2008-11-27 18:08       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081127105931.GD19421@m500.domain \
    --to=olvaffe@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=noodles@earth.li \
    --cc=qce-ga-devel@lists.sourceforge.net \
    --cc=video4linux-list@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.