Re: p54: AP mode: no data frame despite traffic indication set in TIM

[Christian Lamparter <chunkeey@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

On Thursday 27 November 2008 15:13:54 Johannes Berg wrote:
> On Thu, 2008-11-27 at 15:05 +0100, Stefan Steuerwald wrote:
> > I'm unfamiliar with kernel dev procedure. I assume you guys are trying
> > to get confirmation for that and/or submit patches? 
> 
> I've already submitted my patch to John, I suppose Christian will submit
> his and add you as Tested-by.
p54-sta-flags-v3.diff will be submitted on friday/saturday (probably together
with the WEP/TKIP & CCMP offload patch, which could be very useful for
embedded systems accesspoints too)...

But I don't know what to do with set-and-clear.diff 
(I guess it's still one of the three patches, or?, I've attached it again,
in case johannes missed it? ).
Is it really necessary or does your application work without it?

> > If you need me for
> > any of that, I'll be there anytime. Also, a hint on whether to send
> > pizzas or iPods would be appreciated ;-) .
Johannes,

Isn't there a donation page on the wiki yet? I thought there is such
a thing already?!

Regards,
	Chr



[-- Attachment #2: set-and-clear.diff --]
[-- Type: text/x-diff, Size: 930 bytes --]

diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 5a1a60f..077fdb7 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -657,7 +657,8 @@ static void ap_sta_ps_start(struct sta_info *sta)
 	DECLARE_MAC_BUF(mac);
 
 	atomic_inc(&sdata->bss->num_sta_ps);
-	set_and_clear_sta_flags(sta, WLAN_STA_PS, WLAN_STA_PSPOLL);
+	set_and_clear_sta_flags(sta, WLAN_STA_PS, WLAN_STA_PSPOLL |
+				WLAN_STA_CLEAR_PS_FILT);
 #ifdef CONFIG_MAC80211_VERBOSE_PS_DEBUG
 	printk(KERN_DEBUG "%s: STA %s aid %d enters power save mode\n",
 	       sdata->dev->name, print_mac(mac, sta->sta.addr), sta->sta.aid);
@@ -674,7 +675,8 @@ static int ap_sta_ps_end(struct sta_info *sta)
 
 	atomic_dec(&sdata->bss->num_sta_ps);
 
-	clear_sta_flags(sta, WLAN_STA_PS | WLAN_STA_PSPOLL);
+	set_and_clear_sta_flags(sta, WLAN_STA_CLEAR_PS_FILT,
+				WLAN_STA_PS | WLAN_STA_PSPOLL);
 
 	if (!skb_queue_empty(&sta->ps_tx_buf))
 		sta_info_clear_tim_bit(sta);