From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1L623F-0007z7-3U
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 07:02:25 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1L623C-0007yH-30
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 07:02:24 -0500
Received: from [199.232.76.173] (port=38736 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1L623B-0007yD-WC
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 07:02:22 -0500
Received: from outbound-dub.frontbridge.com ([213.199.154.16]:49444
	helo=IE1EHSOBE003.bigfish.com)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16)
	(Exim 4.60) (envelope-from <Christoph.Egger@amd.com>)
	id 1L623B-0001RJ-DB
	for qemu-devel@nongnu.org; Fri, 28 Nov 2008 07:02:21 -0500
Content-Disposition: inline
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [Qemu-devel] Re: [PATCH 2/6] qemu fixes
Date: Fri, 28 Nov 2008 14:01:37 +0200
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-ID: <200811281301.37585.Christoph.Egger@amd.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>, Jan Kiszka <jan.kiszka@siemens.com>


On Friday 28 November 2008 12:44:33 you wrote:
> Christoph Egger wrote:
> > Hi,
> >
> > This is a series of four patches which improve support
> > for qemu on NetBSD.
> >
> > Attached patch fixes warnings in the i386 specific part.
> >
> > Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
>
> Except for ss* in [copy, paste, sigh]...
>
> > @@ -2275,8 +2275,8 @@
> >                              int shift, int next_eip_addend)
> >  {
> >      int new_stack, i;
> > -    uint32_t e1, e2, cpl, dpl, rpl, selector, offset, param_count;
> > -    uint32_t ss, ss_e1, ss_e2, sp, type, ss_dpl, sp_mask;
> > +    uint32_t e1 =3D 0, e2 =3D 0, cpl, dpl, rpl, selector, offset,
> > param_count; +    uint32_t ss =3D 0, ss_e1 =3D 0, ss_e2 =3D 0, sp, type,
> > ss_dpl, sp_mask; uint32_t val, limit, old_sp_mask;
> >      target_ulong ssp, old_ssp, next_eip;
>
> I have a better patch here that fixes the root of gcc's confusion:
> missing noreturn instrumentation. The detection of the initialization of
> ss* variables falls into the category "gcc isn't smart enough", and one
> may discuss if we should handle it or wait for gcc getting smarter. BTW,
> this patch is not BSD specific but gcc4 related.

Well, go ahead then.

> Nevertheless, warning reduction patches are generally welcome IMHO!

Nice to hear.

Christoph

=2D-=20
AMD Saxony, Dresden, Germany
Operating System Research Center

Legal Information:
AMD Saxony Limited Liability Company & Co. KG
Sitz (Gesch=E4ftsanschrift):
   Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
vertretungsberechtigter Komplement=E4r:
   AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Gesch=E4ftsf=FChrer der AMD Saxony LLC:
   Dr. Hans-R. Deppe, Thomas McCoy