From: Ingo Molnar <mingo@elte.hu>
To: Cliff Wickman <cpw@sgi.com>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: uv bau interrupt -- use proper interrupt number
Date: Fri, 28 Nov 2008 14:17:56 +0100 [thread overview]
Message-ID: <20081128131756.GA28138@elte.hu> (raw)
In-Reply-To: <20081126211841.GA20309@sgi.com>
* Cliff Wickman <cpw@sgi.com> wrote:
> On Thu, Nov 27, 2008 at 12:02:10AM +0300, Cyrill Gorcunov wrote:
> > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> > CC: Andi Kleen <andi@firstfloor.org>
> > ---
> > arch/x86/kernel/entry_64.S | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-2.6.git/arch/x86/kernel/entry_64.S
> > ===================================================================
> > --- linux-2.6.git.orig/arch/x86/kernel/entry_64.S
> > +++ linux-2.6.git/arch/x86/kernel/entry_64.S
> > @@ -945,7 +945,7 @@ apicinterrupt IRQ_MOVE_CLEANUP_VECTOR \
> > irq_move_cleanup_interrupt smp_irq_move_cleanup_interrupt
> > #endif
> >
> > -apicinterrupt 220 \
> > +apicinterrupt UV_BAU_MESSAGE \
> > uv_bau_message_intr1 uv_bau_message_interrupt
> > apicinterrupt LOCAL_TIMER_VECTOR \
> > apic_timer_interrupt smp_apic_timer_interrupt
> > --
>
> The interrupt handler does not use the hardcoded 220, but
> the declaration should indeed be fixed as above.
> (such a fix was once submitted
> http://marc.info/?l=linux-kernel&m=122350309029050&w=2 but didn't
> go anywhere)
> Thanks for the follow-up.
applied to tip/x86/irq, thanks guys!
Ingo
prev parent reply other threads:[~2008-11-28 13:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 21:02 [PATCH] x86: uv bau interrupt -- use proper interrupt number Cyrill Gorcunov
2008-11-26 21:18 ` Cliff Wickman
2008-11-28 13:17 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081128131756.GA28138@elte.hu \
--to=mingo@elte.hu \
--cc=andi@firstfloor.org \
--cc=cpw@sgi.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.