From: Alan Cox <alan@redhat.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Keith Packard <keithp@keithp.com>,
linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH] usb/serial: Add compat_ioctl pass-through
Date: Fri, 28 Nov 2008 09:03:35 -0500 [thread overview]
Message-ID: <20081128140335.GA21358@shell.devel.redhat.com> (raw)
In-Reply-To: <200811281243.02841.arnd@arndb.de>
On Fri, Nov 28, 2008 at 12:43:02PM +0100, Arnd Bergmann wrote:
> I've just checked all tty device drivers. The only one using the file
> pointer in ->ioctl, ->tiocmget and ->tiocmset is serial_core, which
> passes it to tty_hung_up_p(). That could easily be changed to check
> (tty->flags & TTY_HUPPED) AFAICT.
>
> Maybe Alan can comment on this. I think the code would become cleaner
> if we dropped the file argument to these three functions throughout
> the tty layer, but it's probably not worth the pain to change themm
> call.
Removing it seems a bit pointless as someone will one day no doubt need
to put it back again
next prev parent reply other threads:[~2008-11-28 14:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-27 8:29 [PATCH] usb/serial: Add compat_ioctl pass-through Keith Packard
2008-11-27 8:29 ` [PATCH] usb/serial/cp2101: Add support for cp2103 GPIO pins Keith Packard
2008-11-27 10:58 ` Alan Cox
2008-11-27 18:20 ` Keith Packard
2008-11-27 18:41 ` Greg KH
2008-11-28 1:31 ` Keith Packard
2008-12-03 7:12 ` Greg KH
2008-12-03 8:11 ` Keith Packard
2008-11-27 14:31 ` [PATCH] usb/serial: Add compat_ioctl pass-through Arnd Bergmann
2008-11-27 18:27 ` Keith Packard
2008-11-28 11:43 ` Arnd Bergmann
2008-11-28 14:03 ` Alan Cox [this message]
2008-11-28 15:42 ` Arnd Bergmann
2008-11-28 22:28 ` Keith Packard
2008-11-28 22:33 ` Alan Cox
2008-11-29 1:02 ` Keith Packard
2008-11-29 1:10 ` Alan Cox
2008-11-29 1:23 ` Arjan van de Ven
2008-11-29 1:37 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081128140335.GA21358@shell.devel.redhat.com \
--to=alan@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@suse.de \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.