Re: [PATCH] Add OMAP2 camera driver

[Tony Lindgren <tony@atomide.com>]

* Trilok Soni <soni.trilok@gmail.com> [081127 09:42]:
> Hi Sakari,
> 
> >
> > It *might* be possible that the same camera block would be used in non-OMAP
> > CPUs as well but I guess it is safe to assume that it depends on ARCH_OMAP
> > now.
> 
> Right, better to keep ARCH_OMAP as dependancy.
> 
> >>
> >> Thanks for the review comments. I will resubmit the patch.
> >
> > Is this exactly the same code that was removed from linux-omap a while ago?
> >
> > ---
> > commit ebdae9abf598ae8a3ee1c8c477138f82b40e7809
> > Author: Tony Lindgren <tony@atomide.com>
> > Date:   Mon Oct 27 13:33:13 2008 -0700
> >
> >    REMOVE OMAP LEGACY CODE: Delete all old omap specific v4l drivers
> >
> >    All v4l development must be done on the v4l mailing list with linux-omap
> >    list cc'd.
> >
> >    Signed-off-by: Tony Lindgren <tony@atomide.com>
> >
> 
> Yes, it the same commit from which I have based this patch.
> 
> > ---
> >
> > Although I haven't had time to discuss this anywhere, I though a possible
> > reason of for the removal was that some parts of the code are not that
> > pretty (e.g. DMA) and those parts should be rewritten.

Well mostly the motivation for removal from linux-omap tree was to
send the camera development to v4l list. For the camera DMA issues, I guess
Sakari you know best how it should be handled.

> > But yes, the OMAP 2 camera driver does actually work and I would suppose it
> > has users, too (think N800/N810).
> 
> Yes, I have both ;)
> 
> >
> > I'm in if the aim is to get this back to linux-omap. :-) (Waiting for the
> > next patch from Trilok.)
> 
> It will come down to linux-omap via mainline tree :)

I like that :)

Tony