From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1L685S-0003DC-NA for qemu-devel@nongnu.org; Fri, 28 Nov 2008 13:29:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1L685Q-0003Cz-BH for qemu-devel@nongnu.org; Fri, 28 Nov 2008 13:29:05 -0500 Received: from [199.232.76.173] (port=36918 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1L685Q-0003Cw-5m for qemu-devel@nongnu.org; Fri, 28 Nov 2008 13:29:04 -0500 Received: from relay01.mx.bawue.net ([193.7.176.67]:37259) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1L685P-0004Ux-QI for qemu-devel@nongnu.org; Fri, 28 Nov 2008 13:29:04 -0500 Date: Fri, 28 Nov 2008 19:28:59 +0100 From: Thiemo Seufer Subject: Re: [Qemu-devel] Re: [PATCH 2/2] Add __noreturn function attribute Message-ID: <20081128182859.GA20428@networkno.de> References: <492FDA5D.6080602@siemens.com> <493030EA.4040405@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <493030EA.4040405@web.de> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org Jan Kiszka wrote: > malc wrote: > > On Fri, 28 Nov 2008, Jan Kiszka wrote: > > > >> Introduce __noreturn attribute and attach it to cpu_loop_exit as well as > >> interrupt/exception helpers for i386. This avoids a bunch of gcc4 > >> warnings. > > > > ISO/IEC 9899:1990 > > > > 7.1.3 > > -- All identifiers that begin with an underscore and > > either an uppercase letter or another underscore are > > always reserved for any use. > > ...but commonly used in practice (which is no excuse to do so here, just > an explanation). Given that we have __hidden already, I just followed > the existing pattern. A kernel is free to make its own rules about namespaces, but userland applications like Qemu should adhere to the userland standards. Thiemo