From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Hugh Dickins <hugh@veritas.com>,
Pekka Enberg <penberg@cs.helsinki.fi>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Miles Lane <miles.lane@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, Tejun Heo <htejun@gmail.com>,
Vegard Nossum <vegard.nossum@gmail.com>,
Arjan van de Ven <arjan@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: 2.6.28-rc6-git1 -- BUG: unable to handle kernel paging request at ffff8800be8b0019
Date: Fri, 28 Nov 2008 22:40:48 -0800 [thread overview]
Message-ID: <20081128224048.dbfc9082.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0811271827490.7113@gandalf.stny.rr.com>
On Thu, 27 Nov 2008 18:31:34 -0500 (EST) Steven Rostedt <rostedt@goodmis.org> wrote:
>
> [ Added Frederic ]
>
> On Thu, 27 Nov 2008, Hugh Dickins wrote:
> > break;
> > --- 2.6.28-rc6/include/linux/ftrace.h 2008-11-02 23:17:56.000000000 +0000
> > +++ linux/include/linux/ftrace.h 2008-11-27 16:39:26.000000000 +0000
> > @@ -231,7 +231,7 @@ ftrace_init_module(unsigned long *start,
> >
> > struct boot_trace {
> > pid_t caller;
> > - char func[KSYM_NAME_LEN];
> > + char func[KSYM_SYMBOL_LEN];
> > int result;
> > unsigned long long duration; /* usecs */
> > ktime_t calltime;
>
> Acked-by: Steven Rostedt <srostedt@redhat.com>
>
> The boot tracer was written by Frederic.
>
This makes rather a mess when applied ahead of the (massive) ftrace
changes in linux-next.
afacit these two func[] arrays:
--- /dev/null
+++ b/include/trace/boot.h
@@ -0,0 +1,56 @@
+#ifndef _LINUX_TRACE_BOOT_H
+#define _LINUX_TRACE_BOOT_H
+
+/*
+ * Structure which defines the trace of an initcall
+ * while it is called.
+ * You don't have to fill the func field since it is
+ * only used internally by the tracer.
+ */
+struct boot_trace_call {
+ pid_t caller;
+ char func[KSYM_NAME_LEN];
+};
+
+/*
+ * Structure which defines the trace of an initcall
+ * while it returns.
+ */
+struct boot_trace_ret {
+ char func[KSYM_NAME_LEN];
+ int result;
+ unsigned long long duration; /* nsecs */
+};
will need to be changed to KSYM_SYMBOL_LEN. I think. Please fix it up
carefully when this all lands on your doorstep.
next prev parent reply other threads:[~2008-11-29 6:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-25 16:50 2.6.28-rc6-git1 -- BUG: unable to handle kernel paging request at ffff8800be8b0019 Miles Lane
2008-11-26 23:26 ` Rafael J. Wysocki
2008-11-27 13:37 ` Pekka Enberg
2008-11-27 13:50 ` Vegard Nossum
2008-11-27 13:54 ` Hugh Dickins
2008-11-27 14:13 ` Pekka Enberg
2008-11-27 17:34 ` Hugh Dickins
2008-11-27 21:23 ` Pekka Enberg
2008-11-27 21:56 ` Hugh Dickins
2008-11-27 22:51 ` Christoph Lameter
2008-11-28 7:57 ` Pekka Enberg
2008-11-27 23:27 ` Steven Rostedt
2008-11-27 23:31 ` Steven Rostedt
2008-11-28 0:16 ` Frederic Weisbecker
2008-11-29 6:40 ` Andrew Morton [this message]
2008-11-28 7:56 ` Pekka Enberg
2008-12-01 20:51 ` Andrew Morton
2008-12-01 22:47 ` Hugh Dickins
2008-12-02 0:57 ` Rusty Russell
2008-11-27 16:14 ` Miles Lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081128224048.dbfc9082.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=cl@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=htejun@gmail.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.